Page MenuHomePhabricator

External link icon is not flipped in RTL
Closed, ResolvedPublic

Description

(Sorry if ResourceLoader isn't the right component for this.)

In RTL wikis, the icon displayed next to external links (with the class .external) is backwards for browsers that support data URIs. (That is, it's displaying the same image as is displayed for LTR wikis.)

The CSS code does have the correct image (skins/Vector/images/external-link-rtl-icon.png) in the code within the ordinary url(//bits.wikimedia...), but the embedded version isn't actually of that image. Instead, it's embedding skins/Vector/images/external-link-ltr-icon.png .


Version: 1.24rc
Severity: minor

Details

Reference
bz68326

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 3:35 AM
bzimport set Reference to bz68326.

Change 161245 had a related patch set uploaded by Bartosz Dziewoński:
Fix CSSJanus flipping in LESS mixins and remove broken custom LESS functions

https://gerrit.wikimedia.org/r/161245

Sorry it took so long. The fix is now available and should be applied within days (or weeks, top).

These aren't really dependant, it's just the same thing for a specific image. Duping instead.

  • This bug has been marked as a duplicate of bug 66091 ***

Change 161751 had a related patch set uploaded by Krinkle:
Fix CSSJanus flipping in LESS mixins and remove broken custom LESS functions

https://gerrit.wikimedia.org/r/161751

Change 161245 merged by jenkins-bot:
Fix CSSJanus flipping in LESS mixins and remove broken custom LESS functions

https://gerrit.wikimedia.org/r/161245

Change 161751 merged by jenkins-bot:
Fix CSSJanus flipping in LESS mixins and remove broken custom LESS functions

https://gerrit.wikimedia.org/r/161751

  • This bug has been marked as a duplicate of bug 66091 ***