[HHVM] Tests on Travis are failing (due to HHVM's sqlsite driver)
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Tobi_WMDE_SW
	Aug 14 2014, 9:37 AM

Description

This is due to a DBAL compatibility issue which still exists on master of DBAL.

Version: unspecified
Severity: normal
Whiteboard: u=dev c=backend p=0

Status	Assigned	Task
Duplicate	None	T72716 cannot save badges on Q183 (Germany)
Resolved	None	T73519 Unblock editing the item for Germany (Q183) (Was: Wikimedia Error page on)
Resolved	Lydia_Pintscher	T66415 Make Wikibase compatible with HHVM
Resolved	Lydia_Pintscher	T71526 [HHVM] Tests on Travis are failing (due to HHVM's sqlsite driver)

• bzimport raised the priority of this task from to High.Nov 22 2014, 3:28 AM

• bzimport set Reference to bz69526.

• bzimport added a subscriber: Unknown Object (MLST).

Talked to the DBAL people. They say HHVMs sqlsite driver is not behaving cotrrectly. https://github.com/facebook/hhvm/issues/3467

Per Jeroen: It's not DBAL apparently, but HHVM. While DBAL master's tests fail due to this, if we switch to DBAL master, our CI passes: https://travis-ci.org/wmde/WikibaseQueryEngine/jobs/32550010

bill wrote:

Even though your CI is passing, please note that it is not currently safe to use the HHVM PDO_SQLite adapter, as it doesn't handle errors properly.

I'm geussing this is also an issue for MediaWiki core? Or is core not using PDO for it's SQLSite support?

(In reply to Jeroen De Dauw from comment #4)

I'm geussing this is also an issue for MediaWiki core? Or is core not using
PDO for it's SQLSite support?

No, core uses PDO:Sqlite.

So core is not using PDO for it's SQLSite support but it uses PDO:Sqlite?

Huh? Do we have two things that are named way to similar here?

No, it's the same thing: PDO:Sqlite is the name of a particular driver:)

So then this is an issue for core if it where to use HHVM? Clearly it is not when it's using regular PHP.

bill wrote:

Lydia_Pintscher removed a subscriber: Unknown Object (MLST).

Lydia_Pintscher removed a subscriber: Unknown Object (MLST).Dec 1 2014, 2:33 PM

Lydia_Pintscher claimed this task.