Page MenuHomePhabricator

echo notifications do not reflect current topic names if changed
Open, MediumPublic

Description

Topic names in echo should reflect the topic they will take me to, irrespective of the topic has changed names (e.g. if the topic name changes echo notifications after the name change should reflect in the echo notifications after the change)


Version: unspecified
Severity: normal

Details

Reference
bz69883

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:34 AM
bzimport set Reference to bz69883.
bzimport added a subscriber: Unknown Object (MLST).
  • Bug 69881 has been marked as a duplicate of this bug. ***

please provide me source code. I want to work on this bug.

I tried this out on Mediawiki:Talk:Sandbox.

I used two accounts: DannyH_(WMF) and a sockpuppet, BanjoDog.

  • DannyH created a thread called "Apples".
  • BanjoDog posted a comment on the thread.
  • DannyH has an Echo notification:
    • <Apples: BanjoDog responded on Talk:Sandbox.>
  • BanjoDog changed the name of the thread to "Bananas".
  • DannyH now has two notifications.
    • <Apples: BanjoDog responded on Talk:Sandbox.>
    • <BanjoDog changed the title of Bananas to "Bananas" on Talk:Sandbox. >
  • BanjoDog added a new comment to "Bananas".
  • DannyH now has two notifications.
    • <Bananas: BanjoDog responded on Talk:Sandbox.>
    • <BanjoDog changed the title of Bananas to "Bananas" on Talk:Sandbox. >

The obvious flaw is that the "changed the title" notification should say: <BanjoDog changed the title of Apples to "Bananas" on Talk:Sandbox.> -- instead of <Bananas to "Bananas">

It would be nice if the title in the original notification changed even if there aren't any new responses in that thread, but I think it's fine the way it is, if we can fix the <Bananas to "Bananas"> bug.

on, Quora where I'm used to seeing the behavior all references (even past ones) to the previous name are changed to the new name except the one that mentions the change. I think both options could work, they both have pros and cons. I'm tempted to say the specific issue you mentioned above should be logged as a seperate task, prioritized high, and this one should be deprioritized until we receive further feedback.

Mattflaschen-WMF set Security to None.

Also mentioned at https://en.wikipedia.org/w/index.php?title=Wikipedia_talk:Flow&oldid=661470042#Renaming_issue.3F

When a thread on the Developer test page had its name changed, the notification was incorrect. As can be seen here, it showed the name which it was changed to twice, instead of the name which was changed from and the name which it was changed to once each.

with this screenshot:

Screen_Shot_2015-05-03_at_11.06.44_AM.png (454×910 px, 73 KB)