fields are too long
input fields are unreasonably long on http://mwui.wmflabs.org/wiki/Special:Preferences#mw-prefsection-editing
Editor Columns and Rows supports a max value of 1000, e.g. 4 characters, the input fields should limit input to 4 characters and be sized such that 4 characters fit comfortably ~70 pixels in length.
Version: unspecified
Severity: normal
Attached:
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Declined | • Mattflaschen-WMF | T99211 Eliminate $wgUseMediaWikiUIEverywhere, leaving 'on' behavior | |||
| Declined | • Mattflaschen-WMF | T72424 Set $wgUseMediaWikiUIEverywhere = true | |||
| Declined | None | T72913 Remove $wgUseMediaWikiUIEverywhere dependency for button and text input styling | |||
| Declined | None | T72405 Special:Preferences: Custom (other) input field for Time offset is too long | |||
| Resolved | None | T72404 Input fields should be relative to input strings | |||
| Declined | • Prtksxna | T72973 Determine how to set input[type=number] visual width (and maybe visual widths of other inputs) | |||
| Declined | None | T72974 maxlength html form values are not used in preferences |
In the style guide inputs are defined as having a width of 100% of the containing element.
We probably need a modifier for these types of input e.g. mw-ui-input q small ?
Note we could use the size attribute but it's not clear how this would work on a mobile device/in a responsive layout.
I wasn't saying the field should be less tall, rather less wide. A standard control is good, just needs to hold fewer characters.
I know. Width 100% = wide.
What should the size be? Should small be the default or should big be the default for input fields?
The input field should suggest to the user the type of content that should be entered. There is no hard and fast rule for open ended fields, however fields with structured input (character limited) should support the number of characters allowed plus consistent padding.
As another example as pointed out by Jared this happens here"
Special:Preferences => Appearance tab => Time offset => Other (specify offset)
Then, the text field below is too long.
Let's apply the mw-ui-inline class and see how that looks.
http://tools.wmflabs.org/styleguide/desktop/section-1.html#section-1.1
Change 161016 had a related patch set uploaded by Prtksxna:
inputs.less: Use .mw-ui-input-inline for type="number"
Change 161016 merged by jenkins-bot:
inputs.less: Use .mw-ui-input-inline for type="number"