Page MenuHomePhabricator

Echo: the Echo flyout should default to the Alert tab, in all cases except when a user just has new Flow notifications
Closed, ResolvedPublic

Description

As a Flow tester, I hence have the Messages tab in my Echo flyout.

If I get a new "Thank" notification, and that changes my Echo Badge to [1], then I expect clicking the [1] will open the Alerts section.

Currently, clicking the badge will always send me to the Messages tab.


Version: unspecified
Severity: normal

Details

Reference
bz70461

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:52 AM
bzimport added a project: Notifications.
bzimport set Reference to bz70461.
bzimport added a subscriber: Unknown Object (MLST).
Quiddity created this task.Sep 5 2014, 8:44 PM

gerritadmin wrote:

Change 158820 had a related patch set uploaded by EBernhardson:
Show alerts tab if active notifications and no messages

https://gerrit.wikimedia.org/r/158820

Note it is this way because that's what the original card asked for.

https://trello.com/c/4Hs9ShSm/334-e-2-separate-notifications-panel-into-messages-and-alerts-13
w"The Messages tab is the default tab that opens when you open the panel."

Are we sure we want to change the behaviour in this situation?
Is messages still the default when there are unread messages and unread alerts?

@jon, good clarification, and nope, we should always default to Alerts when there are unread of both, or no unread of either. (I.e. it should only go straight to Messages if there are only unread Flow notifications). (I've confirmed with Danny)

Update title per further discussion.

  • Bug 70574 has been marked as a duplicate of this bug. ***

gerritadmin wrote:

Change 158820 merged by jenkins-bot:
Default to alerts tab

https://gerrit.wikimedia.org/r/158820

gerritadmin wrote:

Change 159195 had a related patch set uploaded by EBernhardson:
Default to alerts tab

https://gerrit.wikimedia.org/r/159195

gerritadmin wrote:

Change 159195 merged by jenkins-bot:
Default to alerts tab

https://gerrit.wikimedia.org/r/159195

Fixed, live on mediawiki