Page MenuHomePhabricator

Fix extensions depending on skins/common/
Closed, ResolvedPublic

Description

We need to fix extensions depending on skins/common/ before we kill it. There's a bunch that all require small changes, so I'm not going to file a separate bug for every one.


Version: 1.24rc
Severity: normal

Details

Reference
bz70615

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 3:46 AM
bzimport added a project: MediaWiki-General.
bzimport set Reference to bz70615.
matmarex created this task.Sep 9 2014, 5:08 PM

This is the list of thing I intend to fix or at least carefully look at.

The search returned a lot more results, mostly false positives. I also excluded commented-out code, backwards-compatibility for MW pre 1.17, and things that were clearly broken for a long time already.

Searching 11631 files for "/common[^s]" (regex, case sensitive)

extensions\CleanChanges\CleanChanges_body.php:

531  		global $wgStylePath;
532  		$image = Xml::element( 'img', array(
533: 			'src' => $wgStylePath . '/common/images/magnify-clip.png',
534  			'alt' => $this->msg( 'cleanchanges-showuserlinks' )->text(),
535  			'title' => $this->msg( 'cleanchanges-showuserlinks' )->text(),

extensions\EducationProgram\includes\pagers\EPPager.php:

593  					}
594  
595: 					$image = htmlspecialchars( "$wgStylePath/common/images/$image" );
596  					$link = $this->makeLink(
597  								"<img width=\"12\" height=\"12\" alt=\"$alt\" src=\"$image\" />" .

extensions\IndexFunction\SpecialIndex.php:

66  		global $wgStylePath;
67  
68: 		$encUrl = htmlspecialchars( $wgStylePath . '/common/images/Arr_' . $dir . '.png' );
69  		$encAlt = htmlspecialchars( $alt );
70  		$encTitle = htmlspecialchars( $title );

extensions\InterwikiIntegration\InterwikiIntegrationChangesList.php:

604  		$this->lastdate = '';
605  		$this->rclistOpen = false;
606: 		$script = Html::linkedScript( $wgStylePath . "/common/enhancedchanges.js?$wgStyleVersion" );
607  		return $script;
608  	}
...

1031 protected function arrow( $dir, $alt='', $title='' ) {
1032 global $wgStylePath;
1033: $encUrl = htmlspecialchars( $wgStylePath . '/common/images/Arr_' . $dir . '.png' );
1034 $encAlt = htmlspecialchars( $alt );
1035 $encTitle = htmlspecialchars( $title );

extensions\MultiUpload\SpecialMultiUpload.php:

135  			"<style>#mw-upload-form > :first-child { display:none; }\n"
136  			. ".client-js #mw-upload-form > * { display:none; }\n"
137: 			. ".client-js #mw-upload-form { background-image:url($wgStylePath/common/images/spinner.gif); min-height:20px; min-width:20px; background-repeat:no-repeat; }\n"
138  			. '</style>' );
139  	}

extensions\PerPageLicense\PerPageLicense.php:

52          'cc-0' => array(
53                  'url' => 'http://creativecommons.org/publicdomain/zero/1.0/',
54:                 'src' => "{$wgStylePath}/common/images/cc-by-sa.png",
55                  'alt' => 'Creative Commons 0',
56          ),
57          'cc-by-nc-sa' => array(
58                  'url' => 'http://creativecommons.org/licenses/by-nc/3.0/',
59:                 'src' => "{$wgStylePath}/common/images/cc-by-nc-sa.png",
60                  'alt' => 'Creative Commons Attribution-NonCommercial 3.0 Unported',
61          ),
62          'cc-by' => array(
63                  'url' => 'http://creativecommons.org/licenses/by/3.0/',
64:                 'src' => "{$wgStylePath}/common/images/cc-by.png",
65                  'alt' => 'Creative Commons Attribution 3.0 Unported',
66          ),
67          'cc-by-sa' => array(
68                  'url' => 'http://creativecommons.org/licenses/by-sa/3.0/',
69:                 'src' => "{$wgStylePath}/common/images/cc-by-sa.png",
70                  'alt' => 'Creative Commons Attribution Share-Alike 3.0 Unported',
71          ),
72          'gnu-fdl' => array(
73                  'url' => 'http://www.gnu.org/copyleft/fdl.html',
74:                 'src' => "{$wgStylePath}/common/images/gnu-fdl.png",
75                  'alt' => 'GNU Free Documentation License',
76          ),
77          'public-domain' => array(
78                  'url' => 'http://creativecommons.org/licenses/publicdomain/',
79:                 'src' => "{$wgStylePath}/common/images/public-domain.png",
80                  'alt' => 'public domain'
81          ),

extensions\SecurePoll\includes\pages\ListPage.php:

44  			$msgReason = wfMsgHtml( 'securepoll-strike-reason' );
45  			$encAction = htmlspecialchars( $this->getTitle()->getLocalUrl() );
46: 			$encSpinner = htmlspecialchars( "$wgStylePath/common/images/spinner.gif" );
47  			$script = Skin::makeVariablesScript( array(
48  				'securepoll_strike_button' => wfMsg( 'securepoll-strike-button' ),

extensions\SemanticPageMaker\includes\models\SPM_OM_ParserFunction.php:

26  				$jsm = SMWResourceManager::SINGLETON();
27  				if ( $wgUseAjax ) {
28: 					$jsm->addScriptIf( "{$wgStylePath}/common/ajax.js" );
29  				}
30  				$jsm->addScriptIf( $smwgHaloScriptPath .  '/scripts/prototype.js' );

extensions\SemanticPageMaker\specials\SPMQueryInterface\SPM_QueryInterface.php:

29  			$jsm = SMWResourceManager::SINGLETON();
30  			if ( $wgUseAjax ) {
31: 				$jsm->addScriptIf( "{$wgStylePath}/common/ajax.js" );
32  			}
33  			$jsm->addScriptIf( $smwgHaloScriptPath .  '/scripts/prototype.js' );

extensions\SemanticPageMaker\specials\SPMQueryInterface\SPM_QueryInterface2.php:

29  			$jsm = SMWResourceManager::SINGLETON();
30  			if ( $wgUseAjax ) {
31: 				$jsm->addScriptIf( "{$wgStylePath}/common/ajax.js" );
32  			}
33  			$jsm->addScriptIf( $smwgHaloScriptPath .  '/scripts/prototype.js' );

extensions\SemanticPageMaker\specials\WidgetAssembler\SPM_UploadWindow.php:

841  wgAjaxLicensePreview = {$alp};
842  </script>
843: <script type=\"text/javascript\" src=\"{$wgStylePath}/common/upload.js?{$wgStyleVersion}\"></script>
844  		" );
845

extensions\SemanticResultFormats\formats\Exhibit\SRF_Exhibit.php:

54  
55  		if ( defined( 'MW_SUPPORTS_RESOURCE_MODULES' ) ) {
56: 			SMWOutputs::requireHeadItem( 'exhibit-compat', Html::linkedScript( "$wgScriptPath/common/wikibits.js" ) );
57  		}
58

extensions\TimedMediaHandler\TimedMediaTransformOutput.php:

46  	function getUrl( $sizeOverride = false ){
47  		global $wgStylePath;
48: 		$url = "$wgStylePath/common/images/icons/fileicon-ogg.png";
49  
50  		if ( $this->isVideo ) {

extensions\WikiArticleFeeds\WikiArticleFeeds_body.php:

139  
140  		$result = '<li id="feedlinks">';
141: 		$feedIcon = $wgServer . $wgStylePath . "/common/images/feed-icon.png";
142  
143  		# Test for feedBurner presence

extensions\Wikilog\WlFeed.body.php:

434  		if ( !in_array( 'style', $this->mQuirks ) ) {
435  			echo '<?xml-stylesheet type="text/css" href="' .
436: 				htmlspecialchars( wfExpandUrl( "$wgStylePath/common/feed.css?$wgStyleVersion" ) ) .
437  				'"?' . ">\n";
438  		}

Change 159351 had a related patch set uploaded by Bartosz Dziewoński:
Provide own magnify-clip.png image

https://gerrit.wikimedia.org/r/159351

The ones in SemanticPageMaker seem to be dead code, or I can't figure the thing out. I'd file a bug, but it doesn't have a component. I'll let that be.

Change 159352 had a related patch set uploaded by Bartosz Dziewoński:
Fix reference to wikibits.js

https://gerrit.wikimedia.org/r/159352

Change 159353 had a related patch set uploaded by Bartosz Dziewoński:
Remove reference to feed.css

https://gerrit.wikimedia.org/r/159353

Change 159353 merged by jenkins-bot:
Remove reference to feed.css

https://gerrit.wikimedia.org/r/159353

Change 159361 had a related patch set uploaded by Bartosz Dziewoński:
Correct path to fileicon-ogg.png for MW 1.24

https://gerrit.wikimedia.org/r/159361

InterwikiIntegrationChangesList looks quite broken too. I'll let that be.

Change 159361 merged by jenkins-bot:
Correct path to fileicon-ogg.png for MW 1.24

https://gerrit.wikimedia.org/r/159361

Change 159368 had a related patch set uploaded by Bartosz Dziewoński:
Provide own arrow images

https://gerrit.wikimedia.org/r/159368

Change 159369 had a related patch set uploaded by Bartosz Dziewoński:
Provide own arrow images

https://gerrit.wikimedia.org/r/159369

Change 159368 merged by jenkins-bot:
Provide own arrow images

https://gerrit.wikimedia.org/r/159368

Change 159369 merged by jenkins-bot:
Provide own arrow images

https://gerrit.wikimedia.org/r/159369

Change 159370 had a related patch set uploaded by Bartosz Dziewoński:
Remove usage of spinner.gif

https://gerrit.wikimedia.org/r/159370

Change 159351 merged by jenkins-bot:
Provide own magnify-clip.png image

https://gerrit.wikimedia.org/r/159351

Change 159372 had a related patch set uploaded by Bartosz Dziewoński:
Update path to license footer icons for MW 1.24

https://gerrit.wikimedia.org/r/159372

Change 159373 had a related patch set uploaded by Bartosz Dziewoński:
Use .feedlink class rather than feed-icon.png file

https://gerrit.wikimedia.org/r/159373

Change 159376 had a related patch set uploaded by Bartosz Dziewoński:
Provide own spinner image

https://gerrit.wikimedia.org/r/159376

(This is all.)

Change 159376 merged by jenkins-bot:
Provide own spinner image

https://gerrit.wikimedia.org/r/159376

Four patches remain to be merged:

Change 159352 abandoned by Bartosz Dziewoński:
Fix reference to wikibits.js

Reason:
Per CR, this code is also severely broken and this isn't worth doing.

https://gerrit.wikimedia.org/r/159352

Change 159373 merged by jenkins-bot:
Use .feedlink class rather than feed-icon.png file

https://gerrit.wikimedia.org/r/159373

Change 159372 merged by jenkins-bot:
Update path to license footer icons for MW 1.24

https://gerrit.wikimedia.org/r/159372

Change 159370 merged by jenkins-bot:
Remove usage of spinner.gif

https://gerrit.wikimedia.org/r/159370

All patches merged (or abandoned, in the case of the broken SemanticResultFormats):

https://gerrit.wikimedia.org/r/#/q/bug:70615,n,z