There are a few places in MediaWiki that assume that JS/CSS are only stored in the MediaWiki namespace or in User subpages; basically anything that calls Title::isCssOrJsPage() or isCssJsSubpage().
This isn't a very good assumption, and with the introduction of Gadgets 2.0 and the Gadgets namespace, this will be false.
Version: 1.24rc
Severity: normal
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Invalid | None | T34169 Action to join scripts and styles in one file | |||
| Open | None | T110014 Make gadgets easily customizable (merge Gadgets' branch "gadgetprefs" from GSoC 2011) | |||
| Open | None | T31272 Implement Gadgets 2.0 | |||
| Resolved | Legoktm | T72835 Remove assumption from MediaWiki core that JS/CSS are only in MediaWiki namespace or User subpages |
(In reply to Kunal Mehta (Legoktm) from comment #0)
basically anything that
calls Title::isCssOrJsPage() or isCssJsSubpage().
A lot of these calls seem to be for supporting the deprecated ShowRawCssJs hook. Except that hook was only deprecated in 1.24, so we'll need to wait until 1.25 to kill it :/
gerritadmin wrote:
Change 160392 had a related patch set uploaded by Legoktm:
ResourceLoaderWikiModule: Only check content format instead of namespace
Will this have any impact on things like the visibility of the toolbars (the classic and/or from WikiEditor)? See e.g.:
gerritadmin wrote:
Change 160392 merged by jenkins-bot:
ResourceLoaderWikiModule: Only check content format instead of namespace
All patches mentioned in this report were merged or abandoned - is there more work left to do here (if yes: please reset the bug report status to NEW or ASSIGNED), or can you close this ticket as RESOLVED FIXED?