Page MenuHomePhabricator

VisualEditor: Highlight missing parameters in template dialog when complaining about them
Closed, ResolvedPublic

Description

TODO someone needs to figure out what the visual treatment should look like

The inputs in question already match :required:empty , so we can probably do most of this with CSS.


Version: unspecified
Severity: enhancement

Details

Reference
bz70957

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 3:51 AM
bzimport set Reference to bz70957.
Catrope created this task.Sep 17 2014, 8:10 PM

Possible options:

  • Put a red(?) ring/border around the field
  • Put a red(?) ring/border around the field's label
  • Make the field's indicator red(?)
  • Make the field's background red(?)

This class we'd toggle on/off should probably be in OOUI.

gerritadmin wrote:

Change 161516 had a related patch set uploaded by Alex Monk:
Make InputWidget mixin FlaggedElement

https://gerrit.wikimedia.org/r/161516

gerritadmin wrote:

Change 161613 had a related patch set uploaded by Alex Monk:
Style required but currently-invalid parameters on the template dialog

https://gerrit.wikimedia.org/r/161613

gerritadmin wrote:

Change 161516 merged by jenkins-bot:
TextInputWidget: Determine validity on blur and change.

https://gerrit.wikimedia.org/r/161516

gerritadmin wrote:

Change 162511 had a related patch set uploaded by Alex Monk:
TextInputWidget: Determine validity in onEdit rather than in setValue

https://gerrit.wikimedia.org/r/162511

gerritadmin wrote:

Change 162511 merged by jenkins-bot:
TextInputWidget: Add setValidation function to change pattern used to validate text

https://gerrit.wikimedia.org/r/162511

gerritadmin wrote:

Change 161613 merged by jenkins-bot:
Style required but currently-invalid parameters on the template dialog

https://gerrit.wikimedia.org/r/161613

Verified the fix in production