Page MenuHomePhabricator

VisualEditor: [Regression pre-wmf1] Link button does nothing
Closed, ResolvedPublic

Description

Edit any page on beta labs e.g. http://en.wikipedia.beta.wmflabs.org/wiki/Media_Interface_VisualEditor_Test?veaction=edit

Click the Link button. Nothing happens.

Error console shows "TypeError: this.isValid(...).done is not a function"

No other controls seem to be affected by this issue.


Version: unspecified
Severity: major

Details

Reference
bz71237

Event Timeline

bzimport raised the priority of this task from to Unbreak Now!.Nov 22 2014, 3:52 AM
bzimport set Reference to bz71237.

gerritadmin wrote:

Change 162646 had a related patch set uploaded by Catrope:
Account for isValid() becoming async

https://gerrit.wikimedia.org/r/162646

gerritadmin wrote:

Change 162647 had a related patch set uploaded by Catrope:
Make MWLinkTargetInputWidget#isValid asynchronous

https://gerrit.wikimedia.org/r/162647

gerritadmin wrote:

Change 162646 merged by jenkins-bot:
Account for isValid() becoming async

https://gerrit.wikimedia.org/r/162646

gerritadmin wrote:

Change 162647 merged by jenkins-bot:
Update VE core submodule to master (6e68242)

https://gerrit.wikimedia.org/r/162647

Verified the fix in production