Maniphest T73391

Wrong options for H264: -wpred-dct8x8
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	alex-mashin
	Sep 28 2014, 2:55 PM

Tags

Referenced Files

None

Subscribers

• Fabrice_Florin

View All 10 Subscribers

Description

When transcoding video to MP4 with avconv (packages libav-tools and libavcodec-extra-54), transcoding job fails with:

[NULL @ 0x230a700] [Eval @ 0x7fffaa9238e0] Undefined constant or missing '(' in 'wpred'
[NULL @ 0x230a700] Unable to parse option value "wpred-dct8x8"
[NULL @ 0x230a700] Error setting option flags2 to value -wpred-dct8x8.

Removing "-flags2 -wpred-dct8x8 -level 13" from line 414 of WebVideoTranscode/WebVideoTranscodeJob.php and "-flags2 -wpred-dct8x8 -level 30" from line 418 fixes it.

If these options are necessary in some configurations and cannot be therefore unconditionally removed from function ffmpegAddH264VideoOptions( $options, $pass ), perhaps they should be made configurable from LocalSettings.php.

Version: REL1_23-branch
Severity: normal
OS: Linux

Details

Reference: bz71391

	Subject	Repo	Branch	Lines +/-
	Fix MP4/H.264 transcodes on modern avconv	mediawiki/extensions/TimedMediaHandler	REL1_25	+6 -4
	Fix MP4/H.264 transcodes on modern avconv	mediawiki/extensions/TimedMediaHandler	master	+6 -4

Customize query in gerrit

Related Objects

Mentioned In: rETMH135e138100a9: Fix MP4/H.264 transcodes on modern avconv
rMEXT91c2cae344d8: Updated mediawiki/extensions Project: mediawiki/extensions/TimedMediaHandler…

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:45 AM

• bzimport added a project: TimedMediaHandler.

• bzimport set Reference to bz71391.

• bzimport added a subscriber: Unknown Object (MLST).

alex-mashin created this task.Sep 28 2014, 2:55 PM

• Gilles triaged this task as High priority.Nov 24 2014, 1:55 PM

• Gilles subscribed.

• Gilles added a project: Multimedia.Nov 24 2014, 3:16 PM

Change 219395 had a related patch set uploaded (by Brion VIBBER):
Fix MP4/H.264 transcodes on modern avconv

https://gerrit.wikimedia.org/r/219395

gerritbot added a project: Patch-For-Review.Jun 19 2015, 4:40 PM

Change 219395 merged by jenkins-bot:
Fix MP4/H.264 transcodes on modern avconv

https://gerrit.wikimedia.org/r/219395

Diffusion mentioned this in rMEXT91c2cae344d8: Updated mediawiki/extensions Project: mediawiki/extensions/TimedMediaHandler….Jun 22 2015, 6:44 AM

• brooke mentioned this in rETMH135e138100a9: Fix MP4/H.264 transcodes on modern avconv.Jun 22 2015, 6:45 AM

https://gerrit.wikimedia.org/r/219395 (branch master): WMF-deploy-2015-06-23_(1.26wmf11)

Legoktm removed a subscriber: • Forrestbot.Jun 29 2015, 5:50 PM

Restricted Application added a subscriber: Matanya. · View Herald TranscriptJun 29 2015, 5:50 PM

Patch was merged so think we're ok... closing!

alex-mashin updated the task description. (Show Details)Aug 16 2015, 3:24 AM

alex-mashin set Security to None.

Will you please backport the patch to REL1_25?

Change 243370 had a related patch set uploaded (by Brion VIBBER):
Fix MP4/H.264 transcodes on modern avconv

https://gerrit.wikimedia.org/r/243370

In T73391#1699299, @alex-mashin wrote:

Will you please backport the patch to REL1_25?

done!

I did git reset --hard HEAD; git pull; git checkout REL1_25 and still see -wpred-dct8x8 -level 13.

Agh, failed tests and didn't merge. Will look at it when I'm not in an airport.

Change 243370 merged by jenkins-bot:
Fix MP4/H.264 transcodes on modern avconv

https://gerrit.wikimedia.org/r/243370