Flow: Support wgCapitalLinks = false
Open, MediumPublic
Actions

Assigned To

None

Authored By

	• Mattflaschen-WMF
	Oct 8 2014, 6:53 AM

Description

Currently, the tests fail if wgCapitalLinks is false, which is currently the case if you have CirrusSearch enabled in MediaWiki-Vagrant.

However, we should fix this in our own right. It will be required anyway if we deploy to Wiktionary. I think it may be enough to simply make Flow's topic namespace an alwaysCapitalizedNamespace (which I think would require a hook into core) The alternative could be to set wgCapitalLinkOverrides to true for the topic namespace. I'm not sure which is better. See https://git.wikimedia.org/blob/mediawiki%2Fcore.git/3a0b5d4d0ed8c497e1a96efdae237fb30a1ccd75/includes%2FMWNamespace.php#L362

I haven't yet confirmed Flow is okay with the actual human-readable namespace (e.g. Wikipedia talk) being case-sensitive. For that one, we'll have to support it if/when we run on wgCapitalLinks = false wikis, since e.g. on Wiktionary https://en.wiktionary.org/wiki/Talk:Apple and https://en.wiktionary.org/wiki/Talk:apple are the talk pages for entirely different entries.

Version: master
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=71778

Details

Reference: bz71779

Related Objects

Mentioned In: T73778: CirrusSearch tests should be able to pass with wgCapitalLinks = true

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:53 AM

• bzimport added a project: StructuredDiscussions.

• bzimport set Reference to bz71779.

• bzimport added a subscriber: Unknown Object (MLST).

• Mattflaschen-WMF created this task.Oct 8 2014, 6:53 AM

I tested with:

$wgCapitalLinkOverrides[NS_TOPIC] = true;

This could go in Flow.php I think.

In theory, modifying alwaysCapitalizedNamespaces would be slightly better I think. That would require a hook, though.

I forgot to say, the test worked to get the QUnit passing.

in backlog: https://trello.com/c/2WddEysl

Seems to me Flow should not assume topics are always capitalized, since internally its UUIDs are lowercase. Maybe the tests could query &meta=siteinfo&siprop=namespaces to find out if case="case-sensitive" or "first-letter".

Quiddity removed a subscriber: Maryana.Dec 19 2014, 1:41 AM

EBernhardson triaged this task as Medium priority.Feb 12 2015, 6:55 PM

See also https://gerrit.wikimedia.org/r/#/c/192472/ ("Test only works if NS_MAIN is a capitalized namespace").

Quiddity added a project: Collaboration-Team-Triage.Oct 28 2015, 1:38 AM

Quiddity removed a subscriber: • DannyH.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 28 2015, 1:38 AM

Liuxinyu970226 mentioned this in T73778: CirrusSearch tests should be able to pass with wgCapitalLinks = true.Mar 15 2017, 4:00 PM

EBernhardson unsubscribed.Jul 18 2018, 6:44 PM

Restricted Application added a project: Growth-Team. · View Herald TranscriptJul 18 2018, 6:44 PM

SBisson moved this task from Inbox to Triaged but Future on the Growth-Team board.Jul 20 2018, 5:57 PM

MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 7:05 PM

Aklapper removed a project: Collaboration-Team-Triage.May 25 2021, 9:10 PM

Flow: Support wgCapitalLinks = falseOpen, MediumPublicActions

Description

Details

Related Objects

Event Timeline

Flow: Support wgCapitalLinks = false
Open, MediumPublic
Actions