Page MenuHomePhabricator

VisualEditor: Bring back the edit summary byte counter in the save dialog
Closed, ResolvedPublic

Description

It's ve-ui-mwSaveDialog-editSummary-count in MWSaveDialog, but there are several issues with it:

  • It should be stored in a variable, not searched for using jQuery .find() every time
  • It should be modified with methods on OO.ui.LabelWidget, not jQuery .text()
  • It should actually be visible

I don't know why it's being hidden, but display: none; is set on it, so maybe .hide() is called somewhere?


Version: unspecified
Severity: normal

Details

Reference
bz71837

Event Timeline

bzimport raised the priority of this task from to High.
bzimport set Reference to bz71837.
Catrope created this task.Oct 8 2014, 8:28 PM

gerritadmin wrote:

Change 165871 had a related patch set uploaded by SuchetaG:
Bringing back the edit summary byte counter in the save dialog

https://gerrit.wikimedia.org/r/165871

gerritadmin wrote:

Change 165871 merged by jenkins-bot:
Bringing back the edit summary byte counter in the save dialog

https://gerrit.wikimedia.org/r/165871