Page MenuHomePhabricator
Create Task
Maniphest T73945

MediaWiki UI shows unintentionally on Categories and Contributions due to incorrect use of getConfig return value
Closed, ResolvedPublic
Actions

Description

This affects wmf/1.25wmf2 (currently on all Wikipedias) but not 1.25wmf3 or master. It happened to get fixed by a155ac55ea0854b0989efe23158d33b5a548f14e .

Basically, Special:Categories and Special:Contributions were calling:

if ( $this->getConfig( 'UseMediaWikiUIEverywhere' ) ) {

(passing an unused parameter to a no-args method, then using the config object as a boolean)

instead of the correct:

if ( $this->getConfig()->get( 'UseMediaWikiUIEverywhere' ) ) {

I think we should backport the fix on Monday (it can be done by making the above change rather than the whole a155ac55) since it's very inconsistent (only the button is MW UI, not the text boxes or checkboxes) and Special:Contributions is a prominent page.

Version: 1.25-git
Severity: normal

Details

Reference
bz71945

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:47 AM
• bzimport added a project: MediaWiki-MediaWiki-UI.
• bzimport set Reference to bz71945.
• bzimport added a subscriber: Unknown Object (MLST).
• Mattflaschen-WMF created this task.Oct 11 2014, 9:16 AM
Jdlrobson added a comment.Oct 11 2014, 3:01 PM

See my email to design mailing list UI form standardisation groans

I say we just wait till it corrects itself Thursday. It's just a blue button.

greg added a comment.Oct 12 2014, 9:43 PM

Matt/Jon: If you want to SWAT this out on Tuesday morning that's totally fine.

Jdlrobson added a comment.Oct 12 2014, 9:54 PM

I don't. it's just a fully functional button that just happens to be blue that will go away 2 days later. Seems like a bunch of effort for the sake of 2 days.

Jdlrobson added a comment.Oct 22 2014, 5:20 PM

This is now fixed.

Jdforrester-WMF edited projects, added UI-Standardization; removed MediaWiki-MediaWiki-UI.Dec 3 2014, 7:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL