Page MenuHomePhabricator

Plancake composer dependancy
Closed, ResolvedPublic

Description

We don't "need" to use the Plancake dependency, but the fact it's not just regex probably suggests it might be better in the long run.

We don't have any support for composer stuff in production - we currently just include the pre-prepared vendor repo for core for example.

So this needs a bit of work...

I'm wondering if we should just modify make-wmf-branch to look for composer.json files, run "php composer.phar update --optimize-autoloader", and then add the lot to the "Creating new wmf/1.XXwmfYY" branch commit?


Version: unspecified
Severity: enhancement

Details

Reference
bz72779

Event Timeline

bzimport raised the priority of this task from to Needs Triage.
bzimport set Reference to bz72779.
bzimport added a subscriber: Unknown Object (MLST).
Reedy created this task.Oct 30 2014, 8:15 PM
Reedy added a comment.Oct 30 2014, 8:27 PM

It could go in mediawiki/vendor I guess... Considering vendor is primarly for WMF usage (but others can use it for ease)

mediawiki/vendor is the right place to add composer managed dependencies that are going to be used in WMF production. I wrote an RFC for it and everything. :) https://www.mediawiki.org/wiki/Requests_for_comment/Composer_managed_libraries_for_use_on_WMF_cluster

Working on making this better documented is part of the current "librarization" project that Kunal, Aaron and I are working on.

Should I prepare a patch adding plancake to https://github.com/wikimedia/mediawiki-vendor/blob/master/composer.json and committing the downloaded dependencies into the same repo ?

Change 170369 had a related patch set uploaded by 01tonythomas:
Added the Plancake e-mail parser library to MediaWiki using Composer

https://gerrit.wikimedia.org/r/170369

https://bugzilla.wikimedia.org/show_bug.cgi?id=69019#c6

This shouldn't be a blocker for our deployment right ?

Change 170369 merged by jenkins-bot:
Added the Plancake e-mail parser library to MediaWiki using Composer

https://gerrit.wikimedia.org/r/170369

01tonythomas added a comment.EditedFeb 4 2015, 12:24 PM

Just found that plancake fatals in HHVM:

Feb  4 07:27:28 mw1006:  #012Fatal error: Call to undefined function imap_mime_header_decode() in /srv/mediawiki/php-1.25wmf15/vendor/Plancake/EmailParser/PlancakeEmailParser.php on line 133
Reedy added a comment.EditedFeb 4 2015, 12:26 PM

Just found that plancake fatals in HHVM:

Feb  4 07:27:28 mw1006:  #012Fatal error: Call to undefined function imap_mime_header_decode() in /srv/mediawiki/php-1.25wmf15/vendor/Plancake/EmailParser/PlancakeEmailParser.php on line 133

http://docs.hhvm.com/manual/en/function.imap-mime-header-decode.php is currently broken, but google cache says "NOT SUPPORTED IN HHVM". Not sure if it'll ever be supported

Might want to open a separate issue. And we still need to decide if we're going to continue using Plancake