Page MenuHomePhabricator

In Hive, change webrequest's time_firstbyte from float to double
Closed, ResolvedPublic

Description

time_firstbyte is currently a single-precision float.

Varnish exposes 9 decimal digits. So we should switch time_firstbyte
to double to be able to store all varnish-exposed digits even in corner cases.


Version: unspecified
Severity: normal

Details

Reference
bz73018

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:49 AM
bzimport set Reference to bz73018.
bzimport added a subscriber: Unknown Object (MLST).

gerritadmin wrote:

Change 171264 had a related patch set uploaded by QChris:
Change webrequest's time_firstbyte from float to double

https://gerrit.wikimedia.org/r/171264

gerritadmin wrote:

Change 171264 merged by Ottomata:
Change webrequest's time_firstbyte from float to double

https://gerrit.wikimedia.org/r/171264

float is the devil!!!

sorry, couldn't resist, they cost me three days of pain once in a Berlekamp error corrector.