Page.categories withSortKey ignored
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	jayvdb
	Nov 18 2014, 4:31 PM

Description

Site.pagecategories in core does not accept the parameter withSortKey which was present in compat, and no alternative implementation is available.

Page.categories in core even exposes a withSortKey parameter, which is passes to Site.pagecategories, only for it to be ignored.

Version: core-(2.0)
Severity: major

Details

Reference: bz73561

	Subject	Repo	Branch	Lines +/-
	Implement param with_sort_key in Page.categories()	pywikibot/core	master	+24 -9

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Invalid		None	T72936 Important tasks to be solved (tracking)
		Resolved		Tol	T75561 Page.categories withSortKey ignored

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:51 AM

• bzimport added a project: Pywikibot-General.

• bzimport set Reference to bz73561.

• bzimport added a subscriber: Unknown Object (????).

jayvdb created this task.Nov 18 2014, 4:31 PM

Change 148619 had a related patch set uploaded by John Vandenberg:
Add param "from_raw_text", "props" to Page.categories()

https://gerrit.wikimedia.org/r/148619

Change 174143 had a related patch set uploaded by John Vandenberg:
Page.categories parameter withSortKey ignored

https://gerrit.wikimedia.org/r/174143

(In reply to John Mark Vandenberg from comment #0)

Page.categories in core even exposes a withSortKey parameter

fwiw ... withSortKey parameter isnt in the compat method arguments. However the sort key is populated by getCategoryLinks , which is called by Page.categories if the site doesnt have an API.

Change 174143 merged by jenkins-bot:
Page.categories parameter withSortKey ignored

https://gerrit.wikimedia.org/r/174143

Now to work on merging the real fix...

https://gerrit.wikimedia.org/r/148619

Aklapper added a project: Pywikibot.Nov 27 2014, 4:10 PM

jayvdb moved this task from Backlog to Backwards compatibility on the Pywikibot board.Nov 30 2014, 11:58 AM

jayvdb moved this task from Backlog to Probably core only on the Pywikibot-General board.Dec 4 2014, 9:28 AM

Ricordisamoa subscribed.Jan 7 2015, 4:16 PM

Xqt triaged this task as High priority.May 28 2017, 11:56 AM

Dvorapa moved this task from Probably core only to Backlog on the Pywikibot-General board.Jul 10 2017, 1:50 PM

Aklapper edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.Feb 6 2022, 5:33 PM

I can try to do this — I've got a fix mostly working (using pywikibot.data.api.PropertyGenerator and yielding pywikibot.Categorys, with preloadpages if content) already.