Page MenuHomePhabricator

Page.categories withSortKey ignored
Open, HighPublic

Description

Site.pagecategories in core does not accept the parameter withSortKey which was present in compat, and no alternative implementation is available.

Page.categories in core even exposes a withSortKey parameter, which is passes to Site.pagecategories, only for it to be ignored.


Version: core-(2.0)
Severity: major

Details

Reference
bz73561

Related Objects

StatusSubtypeAssignedTask
InvalidNone
OpenNone

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:51 AM
bzimport set Reference to bz73561.
bzimport added a subscriber: Unknown Object (????).
jayvdb created this task.Nov 18 2014, 4:31 PM

Change 148619 had a related patch set uploaded by John Vandenberg:
Add param "from_raw_text", "props" to Page.categories()

https://gerrit.wikimedia.org/r/148619

Change 174143 had a related patch set uploaded by John Vandenberg:
Page.categories parameter withSortKey ignored

https://gerrit.wikimedia.org/r/174143

(In reply to John Mark Vandenberg from comment #0)

Page.categories in core even exposes a withSortKey parameter

fwiw ... withSortKey parameter isnt in the compat method arguments. However the sort key is populated by getCategoryLinks , which is called by Page.categories if the site doesnt have an API.

Change 174143 merged by jenkins-bot:
Page.categories parameter withSortKey ignored

https://gerrit.wikimedia.org/r/174143

Now to work on merging the real fix...

https://gerrit.wikimedia.org/r/148619

Xqt triaged this task as High priority.May 28 2017, 11:56 AM