Page MenuHomePhabricator
Create Task
Maniphest T75934

interwiki.py -hint: does not translate namespaces
Closed, ResolvedPublic
Actions

Description

pwb.py interwiki.py -prefixindex:User:JAn -family:wikiquote -hint:all

Retrieving 3 pages from wikiquote:cs.
NOTE: [[cs:Uživatel:JAnDbot]]: [[cs:Uživatel:JAnDbot]] gives duplicate interwiki
on same site [[sk:Redaktor:JAnDbot]]
NOTE: [[cs:Uživatel:JAn Dudík]]: [[cs:Uživatel:JAn Dudík]] gives duplicate inter
wiki on same site [[af:Gebruiker:JAn Dudík]]
NOTE: [[cs:Uživatel:JAn Dudík]]: [[cs:Uživatel:JAn Dudík]] gives duplicate inter
wiki on same site [[am:???:JAn Dudík]]
NOTE: [[cs:Uživatel:JAn Dudík]]: [[cs:Uživatel:JAn Dudík]] gives duplicate inter
wiki on same site [[ar:mstkhdm:JAn Dudík]]
NOTE: [[cs:Uživatel:JAn Dudík]]: [[cs:Uživatel:JAn Dudík]] gives duplicate inter
wiki on same site [[az:Istifadeçi:JAn Dudík]]
NOTE: [[cs:Uživatel:JAn Dudík]]: [[cs:Uživatel:JAn Dudík]] gives duplicate inter
wiki on same site [[be:Udzel'nik:JAn Dudík]]
NOTE: [[cs:Uživatel:JAn Dudík/common.js]] does not have any interwiki links
Retrieving 4 pages from wikiquote:az.
NOTE: [[az:Uživatel:JAnDbot]] does not exist. Skipping.
NOTE: [[az:Uživatel:JAn Dudík]] does not exist. Skipping.
NOTE: [[az:Uživatel:JAn Dudík/common.js]] does not exist. Skipping.
Retrieving 4 pages from wikiquote:sk.
NOTE: [[sk:Uživatel:JAnDbot]] does not exist. Skipping.
NOTE: [[sk:Uživatel:JAn Dudík]] does not exist. Skipping.
NOTE: [[sk:Uživatel:JAn Dudík/common.js]] does not exist. Skipping.
Retrieving 4 pages from wikiquote:be.
NOTE: [[be:Uživatel:JAnDbot]] does not exist. Skipping.
NOTE: [[be:Uživatel:JAn Dudík]] does not exist. Skipping.
NOTE: [[be:Uživatel:JAn Dudík/common.js]] does not exist. Skipping.
Retrieving 4 pages from wikiquote:am.
NOTE: [[am:Uživatel:JAnDbot]] does not exist. Skipping.
NOTE: [[am:Uživatel:JAn Dudík]] does not exist. Skipping.
NOTE: [[am:Uživatel:JAn Dudík/common.js]] does not exist. Skipping.
Retrieving 4 pages from wikiquote:af.
NOTE: [[af:Uživatel:JAnDbot]] does not exist. Skipping.
NOTE: [[af:Uživatel:JAn Dudík]] does not exist. Skipping.
NOTE: [[af:Uživatel:JAn Dudík/common.js]] does not exist. Skipping.
Retrieving 4 pages from wikiquote:ar.`

Script should search localized namespace

Details

SubjectRepoBranchLines +/-
Allow titletranslate.translate page to be Nonepywikibot/core2.0+26 -22
Allow titletranslate.translate page to be Nonepywikibot/coremaster+26 -22
[FIX] Handle namespace in a language-agnositc way in titletranslate.pypywikibot/coremaster+5 -8
Customize query in gerrit

Related Objects

Event Timeline

JAnD created this task.Nov 25 2014, 10:20 PM
JAnD raised the priority of this task from to Needs Triage.
JAnD updated the task description. (Show Details)
JAnD added a project: Pywikibot.
JAnD changed Security from none to None.
JAnD subscribed.
JAnD updated the task description. (Show Details)Nov 25 2014, 10:25 PM
jayvdb added a project: Pywikibot-interwiki.py.Dec 24 2014, 1:33 PM
jayvdb subscribed.
JAnD renamed this task from interwiki.py -hint:all does not translate namespaces to interwiki.py -hint: does not translate namespaces.Jan 9 2015, 1:38 PM
JAnD triaged this task as High priority.
JAnD mentioned this in T99365: [RFC] Compat deprecation.May 18 2015, 12:00 PM
Ladsgroup subscribed.May 23 2015, 9:57 AM

I was able to reproduce it and I'm working on it right now.

gerritbot subscribed.May 23 2015, 10:42 AM

Change 212879 had a related patch set uploaded (by Ladsgroup):
[FIX] Handle namespace in a language-agnositc way in titletranslate.py

https://gerrit.wikimedia.org/r/212879

gerritbot added a project: Patch-For-Review.May 23 2015, 10:42 AM
gerritbot added a comment.May 23 2015, 1:42 PM

Change 212879 merged by jenkins-bot:
[FIX] Handle namespace in a language-agnositc way in titletranslate.py

https://gerrit.wikimedia.org/r/212879

Ladsgroup mentioned this in rPWBC60c01fa55245: [FIX] Handle namespace in a language-agnositc way in titletranslate.py.May 23 2015, 1:42 PM
Ladsgroup closed this task as Resolved.May 23 2015, 2:08 PM
Ladsgroup removed a project: Patch-For-Review.
Ladsgroup added a project: Wikimedia-Hackathon-2015.May 24 2015, 11:52 AM
jayvdb reopened this task as Open.EditedJun 21 2015, 2:10 AM

Found a bug in the patch, and I'm working on a solution. Just need to save my current state and return to this later.

$ python3 pwb.py interwiki -wiktionary -simulate -hintsonly -family:wiktionary -lang:fr -hint:all:foo
...
Traceback (most recent call last):
  File "pwb.py", line 226, in <module>
    if not main():
  File "pwb.py", line 220, in main
    run_python_file(filename, [filename] + args, argvu, file_package)
  File "pwb.py", line 87, in run_python_file
    main_mod.__dict__)
  File "./scripts/interwiki.py", line 2634, in <module>
    main()
  File "./scripts/interwiki.py", line 2605, in main
    bot.add(singlePage, hints=globalvar.hints)
  File "./scripts/interwiki.py", line 2118, in add
    subj = Subject(page, hints=hints)
  File "./scripts/interwiki.py", line 868, in __init__
    self.translate(hints, globalvar.hintsareright)
  File "./scripts/interwiki.py", line 943, in translate
    site=site)
  File ".../pywikibot/tools/__init__.py", line 1227, in wrapper
    return obj(*__args, **__kw)
  File ".../pywikibot/titletranslate.py", line 83, in translate
    defaultNamespace=page.namespace())
AttributeError: 'NoneType' object has no attribute 'namespace'
jayvdb claimed this task.Jun 21 2015, 2:11 AM
Qgil moved this task from Backlog to Work continues after Lyon on the Wikimedia-Hackathon-2015 board.Jun 25 2015, 5:51 AM
gerritbot added a comment.Jul 3 2015, 2:45 PM

Change 222606 had a related patch set uploaded (by John Vandenberg):
Fix bug in titletranslate

https://gerrit.wikimedia.org/r/222606

gerritbot added a project: Patch-For-Review.Jul 3 2015, 2:45 PM
gerritbot added a comment.Jul 19 2015, 2:25 PM

Change 222606 merged by jenkins-bot:
Allow titletranslate.translate page to be None

https://gerrit.wikimedia.org/r/222606

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 19 2015, 2:25 PM
Xqt mentioned this in rPWBC95404658bd53: Allow titletranslate.translate page to be None.Jul 19 2015, 2:25 PM
jayvdb closed this task as Resolved.Jul 19 2015, 4:21 PM
gerritbot added a comment.Oct 2 2015, 5:46 AM

Change 243109 had a related patch set uploaded (by John Vandenberg):
Allow titletranslate.translate page to be None

https://gerrit.wikimedia.org/r/243109

gerritbot added a comment.Oct 2 2015, 9:16 PM

Change 243109 merged by jenkins-bot:
Allow titletranslate.translate page to be None

https://gerrit.wikimedia.org/r/243109

jayvdb mentioned this in rPWBCa305d7b66cea: Allow titletranslate.translate page to be None.Oct 2 2015, 9:16 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits