Page MenuHomePhabricator
Create Task
Maniphest T76149

Make the cassandra module use hiera properly
Closed, ResolvedPublic
Actions

Description

Currently, defaults.pp has a lot of pick calls picking up global variables to set up defaults. The defaults should just be set as defaults in init.pp itself, and then hiera can be used to override the class parameters.

default.pp should not exist.

Details

SubjectRepoBranchLines +/-
cassandra: deprecate cassandra::defaults classoperations/puppet/cassandramaster+37 -98
Customize query in gerrit

Related Objects
Search...

Event Timeline

yuvipanda created this task.Nov 27 2014, 3:45 PM
yuvipanda raised the priority of this task from to Needs Triage.
yuvipanda updated the task description. (Show Details)
yuvipanda added projects: acl*sre-team, Puppet.
yuvipanda changed Security from none to None.
yuvipanda added subscribers: yuvipanda, Joe.
yuvipanda added subscribers: • GWicke, cscott.Nov 27 2014, 7:17 PM
yuvipanda renamed this task from Make the cassandra module use hiera to Make the cassandra module use hiera properly.Nov 27 2014, 8:16 PM
yuvipanda updated the task description. (Show Details)
• GWicke added a project: RESTBase-Cassandra.Nov 27 2014, 8:16 PM
• GWicke added a subscriber: Ottomata.
• GWicke added a comment.EditedNov 27 2014, 8:22 PM

Other improvements could be:

  • group the cassandra cluster settings under one per-cluster hierarchy in hiera, so that this hierarchy can be referenced by all users of that cassandra cluster (especially: user, pass, seeds); let an app like restbase reference multiple clusters.

See also: T1228

• GWicke mentioned this in T1228: RESTbase deployment.Nov 27 2014, 8:24 PM
mark edited projects, added ops-core; removed acl*sre-team.Dec 18 2014, 9:13 AM
• chasemp triaged this task as Medium priority.Jan 6 2015, 11:07 PM
• GWicke added a parent task: T89481: RESTBase beta release (revision storage / content API).Feb 13 2015, 6:57 PM
• GWicke removed a parent task: T89481: RESTBase beta release (revision storage / content API).Feb 13 2015, 7:07 PM
fgiunchedi mentioned this in T89657: use correct datacenter/rack for cassandra nodes.Feb 16 2015, 3:42 PM
gerritbot added a project: Patch-For-Review.Feb 16 2015, 4:00 PM
gerritbot subscribed.

Change 190813 had a related patch set uploaded (by Filippo Giunchedi):
cassandra: deprecate cassandra::defaults class

https://gerrit.wikimedia.org/r/190813

Patch-For-Review

fgiunchedi added a parent task: T89657: use correct datacenter/rack for cassandra nodes.Feb 16 2015, 4:02 PM
fgiunchedi claimed this task.Feb 16 2015, 4:13 PM
gerritbot added a comment.Feb 18 2015, 10:03 AM

Change 190813 merged by Filippo Giunchedi:
cassandra: deprecate cassandra::defaults class

https://gerrit.wikimedia.org/r/190813

fgiunchedi added a comment.Feb 18 2015, 10:08 AM

default.pp is gone with https://gerrit.wikimedia.org/r/190813, leaving this open since there other other improvements like @GWicke suggested

fgiunchedi mentioned this in rOPCAbf67814299fc: cassandra: deprecate cassandra::defaults class.Mar 3 2015, 8:45 PM
Ottomata unsubscribed.May 1 2015, 8:29 PM
fgiunchedi mentioned this in rOPUPbf67814299fc: cassandra: deprecate cassandra::defaults class.Jun 25 2015, 9:06 PM
fgiunchedi closed this task as Resolved.Nov 20 2015, 9:39 AM

cassandra module has changed a lot now including support for multi instances, resolving

• Phabricator_maintenance removed a subscriber: yuvipanda.Jun 7 2017, 6:57 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits