Page MenuHomePhabricator
Create Task
Maniphest T76196

Improve language selection when creating a translation
Closed, ResolvedPublic
Actions

Description

Context

Use (and improve) the ULS language list to facilitate language selection on the "new translation" dialog.

Timebox

  • Monday 15 December 2014
  • Tuesday, 10 March 2015

Narrative

As a user, I can easily select my languages of interest so that I have a clear idea as to whether my usual languages are supported and can select them quickly.

Acceptance Criteria

  1. Use a Compact language list as in ULS.
  2. Adjust the list layout to accommodate both long and short lists of languages.
    1. For a reduced number of languages, the number of columns will be reduced.
  3. Allow setting the language selection to a neutral state. Clicking on an “X” icon will undo the selection.
  4. Use decorative styling to distinguish between unavailable languages (not shown), discouraged languages (shown lighter, opacity: 0.5) and regular languages (shown in full opacity) depending on the context (more detail in the design notes).

Design Notes

cx_language-selection.png (768×1 px, 48 KB)

cx_language-selection-columns.png (614×820 px, 178 KB)

Deliverables

Details

SubjectRepoBranchLines +/-
Update jquery.uls from upstreammediawiki/extensions/UniversalLanguageSelectormaster+30 -17
Save the selected language to ULS's previous languagesmediawiki/extensions/ContentTranslationmaster+17 -0
Source selector: Show common languages in the language selectormediawiki/extensions/ContentTranslationmaster+10 -0
ULS width according to the number of languagesmediawiki/extensions/ContentTranslationmaster+26 -1
ULS for source and target selectorsmediawiki/extensions/ContentTranslationmaster+138 -74
Customize query in gerrit

Related Objects

Event Timeline

Arrbee created this task.Nov 28 2014, 8:17 AM
Arrbee assigned this task to Amire80.
Arrbee raised the priority of this task from to Medium.
Arrbee updated the task description. (Show Details)
Arrbee added projects: Language-Team, ContentTranslation.
Arrbee changed Security from none to None.
Arrbee moved this task from Backlog to Sprint Backlog on the Language-Team board.Nov 28 2014, 9:06 AM
Arrbee raised the priority of this task from Medium to High.Nov 28 2014, 9:11 AM
Arrbee moved this task from Sprint Backlog to In Progress on the Language-Team board.
Arrbee lowered the priority of this task from High to Medium.Nov 28 2014, 9:15 AM
Arrbee added a project: ContentTranslation-Release3.Nov 28 2014, 12:01 PM
Arrbee moved this task from Backlog to Sprint 79 on the ContentTranslation-Release3 board.Nov 28 2014, 12:06 PM
Arrbee added a project: LE-Sprint-79.Nov 28 2014, 12:15 PM
Arrbee moved this task from Backlog to In Progress on the LE-Sprint-79 board.Nov 28 2014, 12:23 PM
gerritbot added a project: Patch-For-Review.Dec 2 2014, 7:07 AM

Change 174094 had a related patch set uploaded (by Nikerabbit):
ULS for source and target selectors

https://gerrit.wikimedia.org/r/174094

Patch-For-Review

gerritbot added a comment.Dec 2 2014, 3:37 PM

Change 174094 merged by jenkins-bot:
ULS for source and target selectors

https://gerrit.wikimedia.org/r/174094

Arrbee moved this task from In Progress to In Review on the LE-Sprint-79 board.Dec 3 2014, 7:16 AM
santhosh subscribed.Dec 4 2014, 9:13 AM

Pull request for customizing the ULS dialog width was merged https://github.com/wikimedia/jquery.uls/pull/168

Pginer-WMF subscribed.Dec 5 2014, 2:32 PM

ULS adjustments for map removal were described at https://wikimedia.mingle.thoughtworks.com/projects/language_engineering/cards/4017

Arrbee updated the task description. (Show Details)Dec 9 2014, 3:03 PM
Arrbee updated the task description. (Show Details)
Arrbee added a project: LE-Sprint-80.Dec 9 2014, 3:07 PM
gerritbot added a comment.Dec 10 2014, 5:30 AM

Change 177536 had a related patch set uploaded (by Santhosh):
ULS width according to the number of languages

https://gerrit.wikimedia.org/r/177536

Patch-For-Review

Arrbee moved this task from Backlog to In Review on the LE-Sprint-80 board.Dec 10 2014, 12:38 PM
Arrbee removed a project: LE-Sprint-79.
Arrbee moved this task from Sprint 79 to Sprint 80 on the ContentTranslation-Release3 board.Dec 10 2014, 12:55 PM
• Jsahleen mentioned this in rECTXd0a30f8b9903: ULS for source and target selectors.Dec 10 2014, 4:30 PM
Pginer-WMF added a comment.Dec 11 2014, 10:31 AM

I also noticed that the "Common languages" section was not appearing on labs instance where many languages are available. I expect that section to appear (as it does in ULS) when there are more than 10 languages to facilitate the selection of usual languages for users.
This is already part of the designs, but making it explicit here just in case it helps.

Pginer-WMF added a comment.Dec 11 2014, 10:54 AM

Also related to language selection, we have this comment from the talk page:

when you click "start new translation" it appears two languages selected by deffault (in my case, spanish to catalan)
if you don't click the languages again to "re-select them" I can't start translating.
Hope it clarifies it all. Would be great that, if one language appears as pre-selected, it actually is :-)

Pginer-WMF added a comment.Dec 12 2014, 6:09 PM

I also found a regression: the quick switch of source and target languages is now broken, and this make it possible to select the same language for source and target which should not be possible.

The expected behaviour is: Given that I have selected "Spanish (source) to Catalan (target)", just by changing the target to Spanish, the resulting selection should be "Catalan (source) to Spanish (target)". The same should happen if the source is changed from Spanish to Catalan.

This was described (and implemented) in the original language selection card, so feel free to refer to it for more details.

• Jsahleen subscribed.Dec 12 2014, 6:28 PM

@pginer These regressions are fixed in the following patch which has not been merged yet. I took care of all language selection issues, I believe.

https://gerrit.wikimedia.org/r/#/c/179191/

The commit is associated with the following task:

https://phabricator.wikimedia.org/T76832

Pginer-WMF added a comment.Dec 12 2014, 6:29 PM

Thanks @Jsahleen!

Arrbee subscribed.Dec 15 2014, 7:11 AM

Needs a review for the task to progress: https://github.com/wikimedia/jquery.uls/pull/171

gerritbot added a comment.Dec 22 2014, 12:48 PM

Change 177536 merged by jenkins-bot:
ULS width according to the number of languages

https://gerrit.wikimedia.org/r/177536

• Jsahleen mentioned this in rECTX93962a541f5e: ULS width according to the number of languages.Dec 22 2014, 12:48 PM
Arrbee closed this task as Resolved.Dec 22 2014, 2:21 PM
Arrbee moved this task from In Review to Done on the LE-Sprint-80 board.
Arrbee reopened this task as Open.Feb 24 2015, 2:40 PM
Arrbee edited projects, added LE-Sprint-83, ContentTranslation-Release4; removed LE-Sprint-80, ContentTranslation-Release3.
Arrbee edited a custom field.Feb 25 2015, 5:45 AM
Pginer-WMF added a comment.Feb 25 2015, 12:19 PM

The most important missing piece is showing the "Common languages" section.
We need to make sure that previous selected languages appear there. That is: Once I select a language which was not in that section, the next time I open the selector, I see the language in the "Common languages" section.

Arrbee moved this task from Backlog to Candidates on the LE-Sprint-83 board.Feb 25 2015, 3:28 PM
Arrbee moved this task from Candidates to Backlog on the LE-Sprint-83 board.Feb 25 2015, 3:39 PM
RandomDSdevel updated the task description. (Show Details)Mar 2 2015, 9:39 PM
RandomDSdevel awarded a token.
Arrbee moved this task from Backlog to Sprint 83 on the ContentTranslation-Release4 board.Mar 4 2015, 12:13 PM
Arrbee moved this task from Needs Triage to Long term on the ContentTranslation board.Mar 5 2015, 8:24 AM
Amire80 moved this task from Backlog to In Progress on the LE-Sprint-83 board.Mar 5 2015, 10:42 PM
gerritbot subscribed.Mar 6 2015, 11:14 AM

Change 194851 had a related patch set uploaded (by Santhosh):
Source selector: Show common languages in the language selector

https://gerrit.wikimedia.org/r/194851

Amire80 closed this task as Resolved.Mar 6 2015, 2:02 PM
Amire80 reassigned this task from Amire80 to santhosh.
gerritbot added a comment.Mar 6 2015, 2:02 PM

Change 194851 merged by jenkins-bot:
Source selector: Show common languages in the language selector

https://gerrit.wikimedia.org/r/194851

Amire80 mentioned this in rECTX6dc1ab315fef: Source selector: Show common languages in the language selector.Mar 6 2015, 2:03 PM
Amire80 reopened this task as Open.Mar 6 2015, 2:06 PM
Amire80 claimed this task.
gerritbot added a comment.Mar 9 2015, 9:21 PM

Change 195443 had a related patch set uploaded (by Amire80):
Save the selected language to ULS's previous languages

https://gerrit.wikimedia.org/r/195443

Amire80 moved this task from In Progress to In Review on the LE-Sprint-83 board.Mar 9 2015, 9:50 PM
Arrbee updated the task description. (Show Details)Mar 10 2015, 9:08 AM
gerritbot added a comment.Mar 10 2015, 3:24 PM

Change 195443 merged by jenkins-bot:
Save the selected language to ULS's previous languages

https://gerrit.wikimedia.org/r/195443

Amire80 mentioned this in rECTX6dc3bcb6e57d: Save the selected language to ULS's previous languages.Mar 10 2015, 3:24 PM
Amire80 mentioned this in rMEXTe9cef407baee: Updated mediawiki/extensions Project: mediawiki/extensions/ContentTranslation….Mar 11 2015, 6:21 AM
Amire80 mentioned this in rMEXTb69615b2ffe6: Updated mediawiki/extensions Project: mediawiki/extensions/ContentTranslation….
santhosh mentioned this in rMEXT5246266a0085: Updated mediawiki/extensions Project: mediawiki/extensions/ContentTranslation….Mar 11 2015, 6:28 AM
Diffusion mentioned this in rMEXTe013526978fc: Updated mediawiki/extensions Project: mediawiki/extensions/ContentTranslation….Mar 11 2015, 6:28 AM
Amire80 added a comment.Mar 16 2015, 9:25 AM

Upstream patch in jquery.uls: https://github.com/wikimedia/jquery.uls/pull/181 .

Amire80 added a comment.Mar 16 2015, 9:26 AM

(This latest patch shows the Common languages only when there are more than 12 languages to show.)

Arrbee added a project: ContentTranslation-Release5.Mar 18 2015, 8:21 AM
Pginer-WMF moved this task from Backlog to Bugs on the ContentTranslation-Release5 board.Mar 18 2015, 8:28 AM
Arrbee removed projects: ContentTranslation-Release4, LE-Sprint-83.Mar 30 2015, 10:40 AM
gerritbot added a comment.Apr 8 2015, 11:56 AM

Change 202710 had a related patch set uploaded (by Amire80):
Update from upstream

https://gerrit.wikimedia.org/r/202710

gerritbot added a comment.Apr 8 2015, 2:01 PM

Change 202710 merged by jenkins-bot:
Update jquery.uls from upstream

https://gerrit.wikimedia.org/r/202710

Amire80 mentioned this in rMEXT4b8d37f9c2e1: Updated mediawiki/extensions Project….Apr 8 2015, 2:01 PM
Amire80 mentioned this in rEULSe65202b434d3: Update jquery.uls from upstream.
Amire80 closed this task as Resolved.Apr 8 2015, 2:07 PM
Amire80 removed a project: Patch-For-Review.
Amire80 edited a custom field.
Amire80 moved this task from In Progress to Needs More Information on the Language-Team board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL