Page MenuHomePhabricator

Migrate cosmetic_changes to the core library
Closed, ResolvedPublic

Description

Page save uses the cosmetic changes script, which is not packaged in the core library. In T76320, the hard dependency was broken, but the functionality is missing if the script is not packaged as part of the library.

cosmetic_changes.py needs to be split, moving the toolkit into pywikibot, and leaving a script in the scripts package for adhoc usage of the toolkit (or maybe integrated as an option in touch.py?).

Details

Related Gerrit Patches:

Event Timeline

jayvdb created this task.Dec 1 2014, 9:18 AM
jayvdb claimed this task.
jayvdb raised the priority of this task from to High.
jayvdb updated the task description. (Show Details)
jayvdb changed Security from none to None.
jayvdb added a subscriber: jayvdb.
jayvdb added a comment.Dec 1 2014, 9:23 AM

Also related: T76323 - moving the algorithms into fixes.py , that is a very simple task for a few of the cosmetic changes - others may require fixes to support the transform being a python function.

gerritbot added a subscriber: gerritbot.

Change 190715 had a related patch set uploaded (by Ladsgroup):
Move cosmetic_changes from scripts to pywikibot

https://gerrit.wikimedia.org/r/190715

Patch-For-Review

Change 190715 merged by jenkins-bot:
Move cosmetic_changes from scripts to pywikibot

https://gerrit.wikimedia.org/r/190715

Ladsgroup closed this task as Resolved.May 7 2015, 8:20 AM
Ladsgroup claimed this task.
Ladsgroup removed a project: Patch-For-Review.