Page MenuHomePhabricator

[Story] batch label lookups for onLinkBegin hook handling
Open, HighPublic

Description

there are some opportunities for batching label lookups for the onLinkBegin hook handling in Wikibase Repo

Event Timeline

aude created this task.Dec 1 2014, 10:13 PM
aude raised the priority of this task from to Needs Triage.
aude updated the task description. (Show Details)
aude changed Security from none to None.
aude added a subscriber: aude.
Lydia_Pintscher triaged this task as High priority.Dec 3 2014, 12:33 PM
Lydia_Pintscher removed a subscriber: Unknown Object (MLST).
aude added a comment.Aug 13 2015, 1:43 PM

The hook uses a BufferedTermLookup, but the buffering only works in places were we do prefetching (currently ChangesList for watchlist and recent changes)

we still need to add batching for more places that LinkBegin is used and would be nice if could be done in a way that we don't need bazillion different hooks in different places and duplicate code.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 13 2015, 1:43 PM
aude renamed this task from batch label lookups for onLinkBegin hook handling to [Story] batch label lookups for onLinkBegin hook handling.Aug 13 2015, 1:44 PM