Page MenuHomePhabricator
Create Task
Maniphest T76539

Be able to specify languages for icons (not just use ltr -> rtl substitution)
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

https://gerrit.wikimedia.org/r/#/c/143407/ provides an RTL version of the 'help' icon, but doesn't work because the build process assumes that "file" maps to a string and doesn't resolve the object. Resolving the object would need OOjs UI, however, so… bootstrapping issue?

Details

SubjectRepoBranchLines +/-
ResourceLoaderImage: Allow shorthand syntaxmediawiki/coremaster+16 -1
Support (poorly) per-language icon versions in colorize-svg.jsoojs/uimaster+58 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdforrester-WMF created this task.Dec 3 2014, 12:17 AM
Jdforrester-WMF raised the priority of this task from to High.
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF added a project: OOUI.
Jdforrester-WMF moved this task to Backlog on the OOUI board.
Jdforrester-WMF changed Security from none to None.
Jdforrester-WMF subscribed.
Jdforrester-WMF moved this task from Backlog to Next-up on the OOUI board.Dec 3 2014, 12:27 AM
matmarex subscribed.Jan 10 2015, 9:59 PM

This would require us to generate per-language CSS files for distribution. The syntax you used is supported by MediaWiki's ResourceLoaderImageModule, but currently not by OOUI's image generator thingy.

matmarex added a subtask: T93669: colorize-svg.js must support the same configuration format as MediaWiki's ResourceLoaderImageModule.Mar 23 2015, 9:53 PM
matmarex added a comment.Mar 28 2015, 12:42 AM

For MediaWiki, we can use ResourceLoader and ResourceLoaderImageModule, which support this kind of thing natively.

For standalone OOjs UI, we should try out some magic with :lang() selectors.

Jdforrester-WMF added a comment.Mar 28 2015, 12:47 AM

We could also merge the LTR/RTL stuff together with :dir() selectors, which are coming 'soon' if the current draft of Selectors 4 remains true: http://dev.w3.org/csswg/selectors-4/#the-dir-pseudo.

matmarex claimed this task.Mar 28 2015, 12:51 AM
Jdforrester-WMF added a comment.Mar 28 2015, 1:04 AM

It's be nice to implement a more compact format for our sanity – one proposal:

P448 Possible compact RLIM icon language format
1Current format
2
3"italic": { "file": {
4 "default": "italic-a.svg",
5 "ar": "italic-arab-meem.svg",
6 "be": "italic-k.svg",
7 "cs": "italic-i.svg",
8 "da": "italic-k.svg",
9 "de": "italic-k.svg",
10 "en": "italic-i.svg",
11 "es": "italic-c.svg",
12 "eu": "italic-e.svg",
13 "fa": "italic-arab-keheh-jeem.svg",
14 "fi": "italic-k.svg",
15 "fr": "italic-i.svg",
16 "gl": "italic-c.svg",
17 "he": "italic-i.svg",
18 "hu": "italic-d.svg",
19 "hy": "italic-armn-sha.svg",
20 "it": "italic-c.svg",
21 "ka": "italic-geor-kan.svg",
22 "ksh": "italic-s.svg",
23 "ky": "italic-k.svg",
24 "ml": "italic-i.svg",
25 "nl": "italic-c.svg",
26 "nn": "italic-k.svg",
27 "no": "italic-k.svg",
28 "os": "italic-k.svg",
29 "pl": "italic-i.svg",
30 "pt": "italic-i.svg",
31 "ru": "italic-k.svg",
32 "sv": "italic-k.svg",
33},
34
35
36Current format, grouped
37
38"italic": { "file": {
39 "default": "italic-a.svg",
40 "ar": "italic-arab-meem.svg",
41 "cs": "italic-i.svg",
42 "en": "italic-i.svg",
43 "fr": "italic-i.svg",
44 "he": "italic-i.svg",
45 "ml": "italic-i.svg",
46 "pl": "italic-i.svg",
47 "pt": "italic-i.svg",
48 "be": "italic-k.svg",
49 "da": "italic-k.svg",
50 "de": "italic-k.svg",
51 "fi": "italic-k.svg",
52 "ky": "italic-k.svg",
53 "nn": "italic-k.svg",
54 "no": "italic-k.svg",
55 "os": "italic-k.svg",
56 "sv": "italic-k.svg",
57 "ru": "italic-k.svg",
58 "es": "italic-c.svg",
59 "gl": "italic-c.svg",
60 "it": "italic-c.svg",
61 "nl": "italic-c.svg",
62 "eu": "italic-e.svg",
63 "fa": "italic-arab-keheh-jeem.svg",
64 "hu": "italic-d.svg",
65 "hy": "italic-armn-sha.svg",
66 "ksh": "italic-s.svg",
67 "ka": "italic-geor-kan.svg",
68},
69
70
71
72Compact format
73
74"italic": { "files": {
75 "default": "italic-a.svg",
76 "ar": "italic-arab-meem.svg",
77 "cs,en,fr,he,ml,pl,pt": "italic-i.svg",
78 "be,da,de,fi,ky,nn,no,os,sv,ru": "italic-k.svg",
79 "es,gl,it,nl": "italic-c.svg",
80 "eu": "italic-e.svg",
81 "fa": "italic-arab-keheh-jeem.svg",
82 "hu": "italic-d.svg",
83 "hy": "italic-armn-sha.svg",
84 "ksh": "italic-s.svg",
85 "ka": "italic-geor-kan.svg",
86},

gerritbot subscribed.Apr 2 2015, 4:58 PM

Change 201486 had a related patch set uploaded (by Bartosz Dziewoński):
Support (poorly) per-language icon versions in colorize-svg.js

https://gerrit.wikimedia.org/r/201486

gerritbot added a project: Patch-For-Review.Apr 2 2015, 4:58 PM
gerritbot added a comment.Apr 2 2015, 5:54 PM

Change 201495 had a related patch set uploaded (by Bartosz Dziewoński):
ResourceLoaderImage: Allow shorthand syntax

https://gerrit.wikimedia.org/r/201495

gerritbot added a comment.Apr 2 2015, 6:22 PM

Change 201486 merged by jenkins-bot:
Support (poorly) per-language icon versions in colorize-svg.js

https://gerrit.wikimedia.org/r/201486

matmarex mentioned this in rGOJUdfa2b273fc06: Support (poorly) per-language icon versions in colorize-svg.js.Apr 2 2015, 6:23 PM
Jdforrester-WMF closed this task as Resolved.Apr 2 2015, 10:23 PM
Jdforrester-WMF closed subtask T93669: colorize-svg.js must support the same configuration format as MediaWiki's ResourceLoaderImageModule as Resolved.
Jdforrester-WMF added projects: OOjs-UI-next-release, VisualEditor 2014/15 Q4 blockers.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from Nominated to Done on the VisualEditor 2014/15 Q4 blockers board.
gerritbot added a comment.Apr 6 2015, 6:22 AM

Change 201495 merged by jenkins-bot:
ResourceLoaderImage: Allow shorthand syntax

https://gerrit.wikimedia.org/r/201495

matmarex mentioned this in rMWa3e6df16903a: ResourceLoaderImage: Allow shorthand syntax.Apr 6 2015, 6:23 AM
Jdforrester-WMF edited projects, added OOUI (OOjs-UI-0.9.5); removed OOjs-UI-next-release.Apr 7 2015, 4:26 PM
Jdforrester-WMF added a project: WMF-deploy-2015-04-08_(1.26wmf1).Apr 8 2015, 8:20 PM
Jdforrester-WMF removed a project: Patch-For-Review.Apr 15 2015, 7:35 PM
Jdforrester-WMF moved this task from Next-up to Reviewing on the OOUI board.Apr 29 2015, 9:35 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL