Page MenuHomePhabricator
Create Task
Maniphest T93669

colorize-svg.js must support the same configuration format as MediaWiki's ResourceLoaderImageModule
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

colorize-svg.js must support the same configuration format as MediaWiki's ResourceLoaderImageModule. They have diverged since their creation, and that's blocking us from easily reusing the definitions. ResourceLoaderImageModule's format is better.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Refactor icon handling againBartosz Dziewońskioojs/uimaster+474 -580
ResourceLoaderImageModule: Rename 'image' in descriptors to 'file'Bartosz Dziewońskimediawiki/coremaster+8 -8
Customize query in gerrit

Related Objects
Search...

Event Timeline

• matmarex created this task.Mar 23 2015, 9:52 PM
• matmarex claimed this task.
• matmarex raised the priority of this task from to High.
• matmarex updated the task description. (Show Details)
• matmarex added projects: Technical-Debt, OOUI.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 23 2015, 9:52 PM
• matmarex added a parent task: T76539: Be able to specify languages for icons (not just use ltr -> rtl substitution).Mar 23 2015, 9:53 PM
• matmarex added a subtask: T94073: Get rid of 'type' stuff in ResourceLoaderImageModule and OOUI's colorize-svg.js.Mar 26 2015, 7:42 PM
gerritbot subscribed.Mar 28 2015, 12:06 AM

Change 200272 had a related patch set uploaded (by Bartosz Dziewoński):
Refactor icon handling again

https://gerrit.wikimedia.org/r/200272

gerritbot added a project: Patch-For-Review.Mar 28 2015, 12:06 AM
gerritbot added a comment.Mar 28 2015, 12:45 AM

Change 200275 had a related patch set uploaded (by Bartosz Dziewoński):
ResourceLoaderImageModule: Remove 'image' in descriptors to 'file'

https://gerrit.wikimedia.org/r/200275

Jdforrester-WMF moved this task from Backlog to Doing on the OOUI board.Mar 28 2015, 1:19 AM
Jdforrester-WMF closed subtask T94073: Get rid of 'type' stuff in ResourceLoaderImageModule and OOUI's colorize-svg.js as Resolved.Mar 29 2015, 10:32 PM
gerritbot added a comment.Mar 29 2015, 10:39 PM

Change 200275 merged by jenkins-bot:
ResourceLoaderImageModule: Rename 'image' in descriptors to 'file'

https://gerrit.wikimedia.org/r/200275

• matmarex mentioned this in rMWfca3887393c5: ResourceLoaderImageModule: Rename 'image' in descriptors to 'file'.Mar 29 2015, 10:39 PM
gerritbot added a comment.Mar 30 2015, 9:06 PM

Change 200272 merged by jenkins-bot:
Refactor icon handling again

https://gerrit.wikimedia.org/r/200272

• matmarex mentioned this in rGOJUd11d5c429754: Refactor icon handling again.Mar 30 2015, 9:07 PM
• matmarex added a comment.Mar 31 2015, 11:44 AM

Most of the work is done, but the way we do ltr/rtl versions of icons is awful. T94560: Properly support ltr/rtl icon versions in colorize-svg.js tracks that. I think this is the last blocker left.

Jdforrester-WMF added a project: VisualEditor 2014/15 Q4 blockers.Apr 1 2015, 7:16 PM
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF closed this task as Resolved.Apr 2 2015, 10:23 PM
Jdforrester-WMF closed subtask T94560: Properly support ltr/rtl icon versions in colorize-svg.js as Resolved.
Jdforrester-WMF added a project: OOjs-UI-next-release.
Jdforrester-WMF moved this task from Nominated to Done on the VisualEditor 2014/15 Q4 blockers board.
Jdforrester-WMF edited projects, added: OOUI (OOjs-UI-0.9.5); removed: OOjs-UI-next-release.Apr 7 2015, 4:26 PM
Jdforrester-WMF added a project: WMF-deploy-2015-04-08_(1.26wmf1).Apr 8 2015, 8:20 PM
Jdforrester-WMF removed a project: Patch-For-Review.Apr 15 2015, 7:35 PM
Jdforrester-WMF moved this task from Doing to Reviewing on the OOUI board.Apr 29 2015, 9:35 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits