colorize-svg.js must support the same configuration format as MediaWiki's ResourceLoaderImageModule. They have diverged since their creation, and that's blocking us from easily reusing the definitions. ResourceLoaderImageModule's format is better.
Description
Description
Details
Details
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
Refactor icon handling again | oojs/ui | master | +474 -580 | |
ResourceLoaderImageModule: Rename 'image' in descriptors to 'file' | mediawiki/core | master | +8 -8 |
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Declined | None | T76633 Move the "WikimediaUI" OOjs UI theme to the MediaWiki repo | |||
Resolved | matmarex | T92551 RL manifest for OOjs UI icon packs should be better | |||
Resolved | Jdforrester-WMF | T76540 Provide an RTL variant of the 'help' icon, but don't use it for he and yi | |||
Resolved | matmarex | T76539 Be able to specify languages for icons (not just use ltr -> rtl substitution) | |||
Resolved | matmarex | T93669 colorize-svg.js must support the same configuration format as MediaWiki's ResourceLoaderImageModule | |||
Resolved | matmarex | T94073 Get rid of 'type' stuff in ResourceLoaderImageModule and OOUI's colorize-svg.js | |||
Resolved | matmarex | T78215 ResourceLoaderImage module css rules should be more configurable | |||
Resolved | matmarex | T94560 Properly support ltr/rtl icon versions in colorize-svg.js |
Event Timeline
Comment Actions
Change 200272 had a related patch set uploaded (by Bartosz Dziewoński):
Refactor icon handling again
Comment Actions
Change 200275 had a related patch set uploaded (by Bartosz Dziewoński):
ResourceLoaderImageModule: Remove 'image' in descriptors to 'file'
Comment Actions
Change 200275 merged by jenkins-bot:
ResourceLoaderImageModule: Rename 'image' in descriptors to 'file'
Comment Actions
Most of the work is done, but the way we do ltr/rtl versions of icons is awful. T94560: Properly support ltr/rtl icon versions in colorize-svg.js tracks that. I think this is the last blocker left.