Page MenuHomePhabricator

Ensure JsonContent pages have valid syntax when saved
Closed, ResolvedPublic

Description


See also:

Event Timeline

Krinkle created this task.Dec 3 2014, 1:31 AM
Krinkle updated the task description. (Show Details)
Krinkle raised the priority of this task from to Low.
Krinkle claimed this task.
Krinkle changed Security from none to None.
Krinkle added subscribers: Krinkle, MW-1.25-release.

Isn't this already done?

@Jdforrester-WMF: Nope. JsonContent is not yet used within MediaWiki core. And when I exposed it for some pages (for T76554) I was able to save invalid syntax.

While the JsonContent class was moved to MediaWiki core, the validation is still in individual extensions (such as EventLogging) and is enforced through hooks instead of through Content's own validation infrastructure (which, until previously, didn't even work; see I69f18d9e101).

Change 177171 had a related patch set uploaded (by Krinkle):
content: Refactor and fix various bugs in JsonContent

https://gerrit.wikimedia.org/r/177171

Patch-For-Review

Change 177171 merged by jenkins-bot:
content: Refactor and fix various bugs in JsonContent

https://gerrit.wikimedia.org/r/177171

Legoktm closed this task as Resolved.Dec 24 2014, 5:32 PM
Legoktm added a subscriber: Legoktm.

I think this is fixed now?

Change 430627 had a related patch set uploaded (by Huji; owner: Huji):
[operations/mediawiki-config@master] Add several rights to eliminators in fawiki

https://gerrit.wikimedia.org/r/430627