Page MenuHomePhabricator

In category input field, typing invalid category name doesn't clear suggestions
Closed, ResolvedPublic

Description

In category input field, typing invalid category name doesn't clear suggestions.

To reproduce:

  1. Open page options dialog, "Categories" tab.
  2. Type a potentially valid category name, such as "A". Wait for suggestions to appear.
  3. Type in something invalid, such as "<", afterwards.
    • From this point on, as long as the category name stays invalid, the suggestions will not be updated, even if the original "A" is deleted and replaced with, say, "Z".
    • De-focusing the field and re-focusing it will clear suggestions.
    • Deleting invalid characters will display correct suggestions again.

Details

Related Gerrit Patches:
mediawiki/extensions/VisualEditor : masterMWCategoryInputWidget: Don't explode on invalid titles

Event Timeline

matmarex created this task.Dec 5 2014, 4:00 PM
matmarex raised the priority of this task from to Needs Triage.
matmarex updated the task description. (Show Details)
matmarex added a project: VisualEditor.
matmarex changed Security from none to None.
matmarex added a subscriber: matmarex.
Jdforrester-WMF triaged this task as Medium priority.Dec 5 2014, 7:05 PM
Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.
matmarex added a subscriber: Swainr.Dec 5 2014, 8:07 PM

Looks like it got fixed.But, now when invalid characters are entered in the input field , JS error-

"Uncaught TypeError: Cannot read property 'replace' of null" appears.See screenshot.

matmarex claimed this task.Dec 5 2014, 8:08 PM

Change 177871 had a related patch set uploaded (by Bartosz Dziewoński):
MWCategoryInputWidget: Don't explode on invalid titles

https://gerrit.wikimedia.org/r/177871

Patch-For-Review

Jdforrester-WMF moved this task from Freezer to Blocked on the VisualEditor board.Dec 5 2014, 8:08 PM

Change 177871 merged by jenkins-bot:
MWCategoryInputWidget: Don't explode on invalid titles

https://gerrit.wikimedia.org/r/177871

Jdforrester-WMF moved this task from Blocked to Q4 on the VisualEditor board.Dec 5 2014, 10:05 PM

Verified the fix in Betalabs and test2

Ryasmeen closed this task as Resolved.Dec 10 2014, 11:16 PM
Ryasmeen added a project: Verified-in-Phase0.