Page MenuHomePhabricator
Create Task
Maniphest T78033

We should set "destructive" on parameter remove buttons in the transclusion dialog in VisualEditor when using the OOUI MediaWiki theme
Closed, ResolvedPublic
Actions

Description

See screenshot:

Screen_Shot_2014-12-09_at_11.21.24.png (518×718 px, 50 KB)

Details

SubjectRepoBranchLines +/-
ve.ui.MWParameter*: Use the destructive flag for all four remove buttonsmediawiki/extensions/VisualEditormaster+2 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdforrester-WMF created this task.Dec 9 2014, 8:04 PM
Jdforrester-WMF raised the priority of this task from to Needs Triage.
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF changed Security from none to None.
Jdforrester-WMF subscribed.
Jdforrester-WMF added projects: VisualEditor, OOUI, VisualEditor-MediaWiki.Dec 9 2014, 8:21 PM
Jdforrester-WMF triaged this task as High priority.Dec 9 2014, 8:33 PM
Jdforrester-WMF moved this task from To Triage to TR6: Visual diffs on the VisualEditor board.Dec 9 2014, 8:38 PM
Jdforrester-WMF claimed this task.Dec 9 2014, 9:46 PM
• TrevorParscal subscribed.Dec 9 2014, 11:12 PM

Gosh that looks terrible. I don't know that the style guide actually demands this, because these are secondary actions and should thus be quieter.

gerritbot added a project: Patch-For-Review.Dec 10 2014, 12:02 AM

Change 178717 had a related patch set uploaded (by Jforrester):
ve.ui.MWParameter*: Use the destructive flag for all four remove buttons

https://gerrit.wikimedia.org/r/178717

Patch-For-Review

Jdforrester-WMF added a comment.Dec 10 2014, 12:02 AM
In T78033#835291, @TrevorParscal wrote:

Gosh that looks terrible. I don't know that the style guide actually demands this, because these are secondary actions and should thus be quieter.

Yeah, but consistency…

gerritbot added a comment.Dec 10 2014, 2:04 AM

Change 178717 merged by jenkins-bot:
ve.ui.MWParameter*: Use the destructive flag for all four remove buttons

https://gerrit.wikimedia.org/r/178717

matmarex moved this task from Backlog to Doing on the OOUI board.Dec 10 2014, 5:44 PM
Esanders moved this task from TR6: Visual diffs to Blocked on the VisualEditor board.Dec 10 2014, 6:33 PM
Jdforrester-WMF closed this task as Resolved.Dec 10 2014, 6:45 PM
Jdforrester-WMF moved this task from Blocked to FY 18-19 Q3/Q4 on the VisualEditor board.
Jdforrester-WMF added a project: WMF-deploy-2014-12-17_(1.25wmf13).
Jdforrester-WMF mentioned this in rEVEDeac5aabeb3ba: ve.ui.MWParameter*: Use the destructive flag for all four remove buttons.Dec 10 2014, 8:38 PM
Jdforrester-WMF removed a project: Patch-For-Review.Dec 15 2014, 9:22 PM
Jdforrester-WMF moved this task from Doing to Reviewing on the OOUI board.Mar 26 2015, 8:57 PM
Jdforrester-WMF added a project: VisualEditor pre-2015 work.Aug 5 2015, 12:58 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits