Replace and Replace all buttons are clipped in VisualEditor when using the OOjs UI MediaWiki theme
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

See screenshot:

Details

	Subject	Repo	Branch	Lines +/-
	MediaWiki theme: Make button sizes match Apex	oojs/ui	master	+14 -14

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T49145 Formally deprecate jQuery UI after we've stopped using jQuery UI in extensions and core
Open	None	T100270 Replace use of jQuery UI and MW UI with OOUI across all Wikimedia-deployed extensions and core
Resolved	matmarex	T74715 Convert some MW core special pages to OOUI
Resolved	• TrevorParscal	T74714 Provide the OOUI PHP module inside MW core
Resolved	Jdforrester-WMF	T78054 Switch MediaWiki core's use of OOjs UI to use the MediaWiki theme, not Apex
Resolved	• TrevorParscal	T78169 Buttons in the MediaWiki theme are higher than in Apex theme
Resolved	• TrevorParscal	T78042 Replace and Replace all buttons are clipped in VisualEditor when using the OOjs UI MediaWiki theme

Event Timeline

Jdforrester-WMF created this task.Dec 9 2014, 8:11 PM

Jdforrester-WMF raised the priority of this task from to Needs Triage.

Jdforrester-WMF updated the task description. (Show Details)

Jdforrester-WMF changed Security from none to None.

Jdforrester-WMF subscribed.

Jdforrester-WMF added projects: VisualEditor, OOUI, VisualEditor-MediaWiki.Dec 9 2014, 8:20 PM

Jdforrester-WMF triaged this task as High priority.Dec 9 2014, 8:33 PM

Jdforrester-WMF moved this task from To Triage to TR6: Visual diffs on the VisualEditor board.Dec 9 2014, 8:37 PM

No clipping for me in Chrome of FF, but the thing that really stands out is the massive difference in height between buttons and textboxes. That needs to get fixed.

I'm pretty sure that's by design. The task for figuring out what to do with the massive buttons is T78169.

The clipping depends on zoom level, so probably Chromium rendering bug.

Change 179518 had a related patch set uploaded (by Jforrester):
MediaWiki theme: Make button sizes match Apex

https://gerrit.wikimedia.org/r/179518

Patch-For-Review

Jdforrester-WMF closed this task as Resolved.Dec 12 2014, 7:07 PM

Jdforrester-WMF assigned this task to • TrevorParscal.

Change 179518 merged by jenkins-bot:
MediaWiki theme: Make button sizes match Apex

https://gerrit.wikimedia.org/r/179518

Jdforrester-WMF added a project: WMF-deploy-2014-12-17_(1.25wmf13).Dec 13 2014, 2:26 AM

Jdforrester-WMF removed a project: Patch-For-Review.Dec 15 2014, 9:22 PM

Jdforrester-WMF moved this task from TR6: Visual diffs to FY 18-19 Q3/Q4 on the VisualEditor board.Jan 7 2015, 9:17 PM

Jdforrester-WMF added a project: VisualEditor 2014/15 Q3 blockers.Jan 23 2015, 11:34 PM

Jdforrester-WMF edited a custom field.Feb 2 2015, 7:51 PM

Jdforrester-WMF moved this task from Nominated to Done on the VisualEditor 2014/15 Q3 blockers board.Feb 3 2015, 5:02 PM

Jdforrester-WMF mentioned this in rGOJUc42a2d8f80a9: MediaWiki theme: Make button sizes match Apex.Mar 3 2015, 7:49 PM

Jdforrester-WMF moved this task from Backlog to Reviewing on the OOUI board.Mar 26 2015, 9:01 PM

Jdforrester-WMF added a project: VisualEditor pre-2015 work.Sep 26 2015, 2:32 PM

	F20257: Screen_Shot_2014-12-09_at_11.51.55.png
	Dec 9 2014, 8:11 PM

Replace and Replace all buttons are clipped in VisualEditor when using the OOjs UI MediaWiki themeClosed, ResolvedPublic1 Estimated Story PointsActions

Description

Details

Related ObjectsSearch...

Event Timeline

Replace and Replace all buttons are clipped in VisualEditor when using the OOjs UI MediaWiki theme
Closed, ResolvedPublic1 Estimated Story Points
Actions

Related Objects
Search...