Page MenuHomePhabricator
Create Task
Maniphest T78360

Clicktracking breaks thanks button
Closed, ResolvedPublic
Actions

Description

Thank is broken on diff page: please fix ASAP as it is breaking the feature. When I click

Uncaught Error: Invalid schema "diff-thank". Possible values are: "Watchlist", "Diff", "MainMenu", "UI".

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Match changed MobileWebClickingSchemamediawiki/extensions/Thanksmaster+1 -1
Match changed MobileWebClickingSchemamediawiki/extensions/Thanksmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Dec 12 2014, 1:20 AM
Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a project: Web-Team-Backlog-Archived.
Jdlrobson changed Security from none to None.
Jdlrobson subscribed.
• bmansurov subscribed.Dec 12 2014, 2:13 AM

I'm not able to reproduce this. I can't even find the phrase "diff-thank" in the codebase. Can you help me debug this please? THanks

Jdlrobson added a project: Notifications (Echo).Dec 12 2014, 2:20 AM

@bmansurov I suspect it's in Thanks extension since that's what provides the thanks functionality...

Jdlrobson edited projects, added Thanks; removed Notifications (Echo).Dec 12 2014, 2:20 AM
• Mattflaschen-WMF subscribed.EditedDec 12 2014, 3:35 AM

@Jdlrobson The call is in Thanks. However, it's caused by rEMFR9bfa2dec337d: EventLogging: break up MobileWebClickTracking, which refactored the logging code, but didn't update this call.

• Mattflaschen-WMF triaged this task as Unbreak Now! priority.Dec 12 2014, 3:36 AM
gerritbot added a project: Patch-For-Review.Dec 12 2014, 5:59 AM

Change 179409 had a related patch set uploaded (by Florianschmidtwelzow):
Match changed MobileWebClickingSchema

https://gerrit.wikimedia.org/r/179409

Patch-For-Review

gerritbot added a comment.Dec 12 2014, 6:55 AM

Change 179409 merged by jenkins-bot:
Match changed MobileWebClickingSchema

https://gerrit.wikimedia.org/r/179409

Florian mentioned this in rETHA54952e1b36d1: Match changed MobileWebClickingSchema.Dec 12 2014, 6:58 AM
Florian closed this task as Resolved.Dec 12 2014, 8:13 AM
Florian claimed this task.
• bmansurov added a comment.Dec 12 2014, 3:39 PM

Thanks Florian. I'll remember to update the Thanks extension in the future.

Florian added a comment.Dec 12 2014, 5:55 PM

Maybe a good point to add a comment to our code like:

// Note: If you change something here, make sure, that you change it in other mobile related extensions, too (e.g. Thanks)!

???

Jdlrobson added a comment.Dec 12 2014, 6:57 PM

Yeh any kind of clues like that would be a good idea. JDI :)

Jdlrobson reopened this task as Open.Dec 12 2014, 7:02 PM

Still broken. It logs an event to diff-thank when it should actually be thank according to 10720373

gerritbot added a comment.Dec 12 2014, 7:13 PM

Change 179521 had a related patch set uploaded (by Bmansurov):
Match changed MobileWebClickingSchema

https://gerrit.wikimedia.org/r/179521

Patch-For-Review

gerritbot added a comment.Dec 12 2014, 8:43 PM

Change 179521 merged by jenkins-bot:
Match changed MobileWebClickingSchema

https://gerrit.wikimedia.org/r/179521

• bmansurov mentioned this in rETHA24b0963a9076: Match changed MobileWebClickingSchema.Dec 12 2014, 8:44 PM
Florian closed this task as Resolved.Dec 14 2014, 10:19 PM

Now it is fixed (as far is i can see on betalabs).

Jdforrester-WMF removed a project: Patch-For-Review.Mar 3 2015, 5:27 PM
Florian mentioned this in rMEXTe43707fe26ad: Updated mediawiki/extensions Project: mediawiki/extensions/Thanks….Mar 11 2015, 6:22 AM
• bmansurov mentioned this in rMEXT4edabb931080: Updated mediawiki/extensions Project: mediawiki/extensions/Thanks….Mar 11 2015, 6:22 AM
• Phabricator_maintenance moved this task from Incoming to 2014-15 Q2 on the Web-Team-Backlog-Archived board.Mar 7 2018, 4:35 AM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptMar 7 2018, 4:35 AM
Restricted Application added a subscriber: TerraCodes. · View Herald Transcript
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits