Thank is broken on diff page: please fix ASAP as it is breaking the feature. When I click
Uncaught Error: Invalid schema "diff-thank". Possible values are: "Watchlist", "Diff", "MainMenu", "UI".
Thank is broken on diff page: please fix ASAP as it is breaking the feature. When I click
Uncaught Error: Invalid schema "diff-thank". Possible values are: "Watchlist", "Diff", "MainMenu", "UI".
I'm not able to reproduce this. I can't even find the phrase "diff-thank" in the codebase. Can you help me debug this please? THanks
@bmansurov I suspect it's in Thanks extension since that's what provides the thanks functionality...
@Jdlrobson The call is in Thanks. However, it's caused by rEMFR9bfa2dec337d: EventLogging: break up MobileWebClickTracking, which refactored the logging code, but didn't update this call.
Change 179409 had a related patch set uploaded (by Florianschmidtwelzow):
Match changed MobileWebClickingSchema
Maybe a good point to add a comment to our code like:
// Note: If you change something here, make sure, that you change it in other mobile related extensions, too (e.g. Thanks)!
???
Still broken. It logs an event to diff-thank when it should actually be thank according to 10720373
Change 179521 had a related patch set uploaded (by Bmansurov):
Match changed MobileWebClickingSchema