Page MenuHomePhabricator

Depend on mwparserfromhell consistently across operating systems
Closed, ResolvedPublic


The mwparserfromhell library allows bot developers to focus on actual code instead of regexes.
It should probably be required for many features in pywikibot, not only on *nix.

Automatic Windows builds are worked on upstream:

Event Timeline

Ricordisamoa raised the priority of this task from to Needs Triage.
Ricordisamoa updated the task description. (Show Details)
Ricordisamoa changed Security from none to None.

Any reasons why mwparserfromhell shouldn't be required?

I thought that issue was caused by an incorrectly set-up Windows build environment, which @valhallasw and I resolved by distributing binaries with releases? I'm not clear on this since I haven't looked in a while, but it seems the underlying problem is blocking py3.3 and py3.4 builds. Would fixing that and releasing v0.4 along with the necessary binaries be sufficient to fix this?

I think so, yes, and then we (as pywikibot) need to make sure the wheels actually get used on windows (and, for example, figure out how to provide nightlies that include/install mwparserfromhell). But that should really be a more generic 'dependency management' task.

valhallasw changed the task status from Open to Stalled.Jan 29 2015, 9:58 PM
valhallasw triaged this task as Medium priority.
valhallasw updated the task description. (Show Details)

fwiw, mwparserfromhell 4.0 can now be released with py3.3 & py3.4 support using pure python mode, if nothing else works.

In , we could use 'git+' as the dependency url , which will automatically fallback to pure python mode

yay, mwparserfromhell 4.0 is released.

One of the strongest outcomes of the python wiki library meeting yesterday was that the 'common library' needs to have only one dependency: requests. So if pywikibot is going to be the common library, we need to make mwparserfromhell optional on all platforms.

Change 213480 had a related patch set uploaded (by John Vandenberg):
Set mwparserfromhell as optional on all platforms

Ricordisamoa changed the task status from Stalled to Open.May 25 2015, 2:49 PM

Not stalled anymore.

Change 213480 merged by XZise:
Set mwparserfromhell as optional on all platforms

jayvdb claimed this task.