Page MenuHomePhabricator

Insufficient span tags stripping from copy-and-paste in Safari
Closed, DuplicatePublic

Description

See diffs like https://fr.wikipedia.org/w/index.php?title=Laurence_Jenkell&curid=5925674&diff=109882275&oldid=108191025 or https://fr.wikipedia.org/w/index.php?title=Ludmila_Pagliero&diff=109911855&oldid=109910719 .

Span tags are introduced, most of them look like <span>some text here</span>, but in the second one <span> </span> was added right before the existing <span class="">(</span>[[Rudolf Noureev]]<span class="">) (which had been introduced with this diff).
Notice how removal of categories also happens (I reported this separately a few days ago).

Event Timeline

Elitre raised the priority of this task from to Needs Triage.
Elitre updated the task description. (Show Details)
Elitre added a project: VisualEditor.
Elitre changed Security from none to None.
Elitre added a subscriber: Elitre.

This looks like VE sending Parsoid HTML with the span tags which Parsoid promptly left behind as spans as there is no wikitext equivalents for that. I don't think Parsoid should start stripping span tags. Unless the spans are part of template content and Parsoid left them behind as spans .. but looking at the diffs, that doesn't seem to be the case. Are they left behind from a copy-paste operation?

Jdforrester-WMF renamed this task from Insufficient span tags stripping? to Insufficient span tags stripping from copy-and-paste (?).Dec 18 2014, 8:09 PM
Jdforrester-WMF triaged this task as High priority.
Jdforrester-WMF edited projects, added VisualEditor-CopyPaste; removed Parsoid.

Select a internallink (compulsory) and a space (compulsory) and some text (plain text or internallink) Cmd C => Cmd V anywhere
https://test2.wikipedia.org/w/index.php?title=Drong-3&diff=138634&oldid=138633
Safari 8.0.2 - MAC OS X 10.10.1

Reproduced with Safari 8.0.4 on MacOS X 10.10.2.

  1. Select an internal link, a space and some plain text
  2. Copy
  3. Paste
  4. Click save
  5. Click preview changes
  6. Notice that there's an extra span around the space and plain text in the pasted content
Jdforrester-WMF renamed this task from Insufficient span tags stripping from copy-and-paste (?) to Insufficient span tags stripping from copy-and-paste in Safari.Mar 27 2015, 9:50 PM