Maniphest T78786

Make CirrusSearch updateOneSearchIndexConfig.php code reusable
Closed, ResolvedPublic
Actions

Description

Flow needed bits of code in updateOneSearchIndexConfig.php, but can't extend from it because:

maintenance scripts have require_once RUN_MAINTENANCE_IF_MAIN;
private methods/properties that can't be extended
statics, mostly referencing Connection::* data, which is specific to core MW data
usage of $wgCirrus* globals

https://gerrit.wikimedia.org/r/#/c/164967/ (merged)
https://gerrit.wikimedia.org/r/#/c/164971/ (merged)
https://gerrit.wikimedia.org/r/#/c/164965/ (merged)
https://gerrit.wikimedia.org/r/#/c/164966/ (merged)
https://gerrit.wikimedia.org/r/#/c/164968/ (merged)
https://gerrit.wikimedia.org/r/#/c/164969/ (merged)
https://gerrit.wikimedia.org/r/#/c/175716/ (merged)
https://gerrit.wikimedia.org/r/#/c/175999/ (merged)
https://gerrit.wikimedia.org/r/#/c/176000/ (merged)
https://gerrit.wikimedia.org/r/#/c/176285/ (merged)
https://gerrit.wikimedia.org/r/#/c/176286/ (merged)
https://gerrit.wikimedia.org/r/#/c/176946/ (merged)
https://gerrit.wikimedia.org/r/#/c/177222/ (merged)
https://gerrit.wikimedia.org/r/#/c/177223/ (merged)
https://gerrit.wikimedia.org/r/#/c/177551/ (merged)
https://gerrit.wikimedia.org/r/#/c/179923/ (merged)
https://gerrit.wikimedia.org/r/#/c/182824/ (merged)
https://gerrit.wikimedia.org/r/#/c/182825/ (merged)
https://gerrit.wikimedia.org/r/#/c/183040/ (merged)
https://gerrit.wikimedia.org/r/#/c/183267/ (merged)
https://gerrit.wikimedia.org/r/#/c/183268/ (merged)
https://gerrit.wikimedia.org/r/#/c/179924/
https://gerrit.wikimedia.org/r/#/c/183269/
https://gerrit.wikimedia.org/r/#/c/183313/
https://gerrit.wikimedia.org/r/#/c/183533/

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		• DannyH	T171977 Annual Plan 2017-2018, Audiences 5: Increase current editor retention and engagement
		Resolved		• DannyH	T171982 Annual Plan 2017-2018, Audiences 5, Goal 3: Provide better workflow and communication experiences
		Open		None	T167928 Improve structured discussion features for the communities that use them, based on user feedback and prioritising technical debt
		Open		None	T170530 Reconsider how to navigate on a Flow board
		Invalid		None	T104631 [DO NOT USE] Search in Flow boards (tracking)
		Open		None	T76823 Basic search on Flow board (tracking)
		Open		None	T78796 Figure out how to deploy Flow search
		Resolved		matthiasmullie	T78787 U8. Make ES configuration management maintenance script
		Resolved		matthiasmullie	T78786 Make CirrusSearch updateOneSearchIndexConfig.php code reusable

Event Timeline

matthiasmullie created this task.Dec 17 2014, 2:40 PM

matthiasmullie claimed this task.

matthiasmullie raised the priority of this task from to Medium.

matthiasmullie updated the task description. (Show Details)

matthiasmullie added projects: StructuredDiscussions, Collaboration-Team-Triage, CirrusSearch.

matthiasmullie changed Security from none to None.

matthiasmullie mentioned this in T78787: U8. Make ES configuration management maintenance script.

matthiasmullie subscribed.

matthiasmullie moved this task from Untriaged to Code Review on the Collaboration-Team-Triage board.Dec 17 2014, 3:34 PM

matthiasmullie mentioned this in T76584: SEARCH BACK-END (L108) Search back-end: Adapt parts of CirrusSearch for Flow data (8).Dec 17 2014, 3:55 PM

matthiasmullie updated the task description. (Show Details)Jan 6 2015, 8:54 AM

matthiasmullie updated the task description. (Show Details)

matthiasmullie updated the task description. (Show Details)Jan 8 2015, 1:14 PM

matthiasmullie updated the task description. (Show Details)Jan 8 2015, 5:01 PM

matthiasmullie updated the task description. (Show Details)Jan 13 2015, 4:11 PM

• Mattflaschen-WMF added a project: Collaboration-Team-Sprint-P-2015-02-11/q3.Jan 28 2015, 7:23 PM

• Mattflaschen-WMF subscribed.

matthiasmullie moved this task from Sprint P - ends Feb 11 to Code Review on the Collaboration-Team-Sprint-P-2015-02-11/q3 board.Jan 28 2015, 7:27 PM

• Mattflaschen-WMF removed a project: Collaboration-Team-Triage.Jan 28 2015, 7:30 PM

• DannyH added a project: Collaboration-Team-Sprint-Q-2015-02-25.Feb 11 2015, 9:26 PM

• DannyH moved this task from Sprint Q - ends Feb 25 to Code Review on the Collaboration-Team-Sprint-Q-2015-02-25 board.

EBernhardson updated the task description. (Show Details)Feb 18 2015, 7:02 PM

EBernhardson updated the task description. (Show Details)Feb 18 2015, 7:04 PM

• DannyH added a project: Collaboration-Team-Sprint-R-2015-03-11.Feb 25 2015, 9:21 PM

• DannyH moved this task from Sprint R - ends March 11 to Code Review Started on the Collaboration-Team-Sprint-R-2015-03-11 board.

• DannyH added a project: Collaboration-Team-Sprint-S-2015-03-25.Mar 11 2015, 9:58 PM

• DannyH moved this task from Sprint S - ends March 25 to Code Review Started on the Collaboration-Team-Sprint-S-2015-03-25 board.

• DannyH added a project: Collaboration-Team-Sprint-T-2015-04-08.Mar 25 2015, 7:21 PM

• DannyH moved this task from Sprint T - ends April 8 to Code Review Started on the Collaboration-Team-Sprint-T-2015-04-08 board.

EBernhardson moved this task from Code Review Started to Needs Code Review on the Collaboration-Team-Sprint-T-2015-04-08 board.Apr 2 2015, 10:05 PM

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptApr 2 2015, 10:05 PM

All linked CirrusSearch patches have been merged

EBernhardson moved this task from Needs Code Review to Product Review on the Collaboration-Team-Sprint-T-2015-04-08 board.Apr 6 2015, 9:15 PM

• DannyH moved this task from Product Review to Done on the Collaboration-Team-Sprint-T-2015-04-08 board.Apr 7 2015, 12:04 AM

matthiasmullie moved this task from Code Review Started to Done on the Collaboration-Team-Sprint-S-2015-03-25 board.Apr 8 2015, 12:34 PM

• Deskana moved this task from Inbox to Resolved/Invalid/Declined/Legacy on the CirrusSearch board.Apr 20 2015, 4:05 AM