Page MenuHomePhabricator

Make CirrusSearch updateOneSearchIndexConfig.php code reusable
Closed, ResolvedPublic

Description

Flow needed bits of code in updateOneSearchIndexConfig.php, but can't extend from it because:

  • maintenance scripts have require_once RUN_MAINTENANCE_IF_MAIN;
  • private methods/properties that can't be extended
  • statics, mostly referencing Connection::* data, which is specific to core MW data
  • usage of $wgCirrus* globals

https://gerrit.wikimedia.org/r/#/c/164967/ (merged)
https://gerrit.wikimedia.org/r/#/c/164971/ (merged)
https://gerrit.wikimedia.org/r/#/c/164965/ (merged)
https://gerrit.wikimedia.org/r/#/c/164966/ (merged)
https://gerrit.wikimedia.org/r/#/c/164968/ (merged)
https://gerrit.wikimedia.org/r/#/c/164969/ (merged)
https://gerrit.wikimedia.org/r/#/c/175716/ (merged)
https://gerrit.wikimedia.org/r/#/c/175999/ (merged)
https://gerrit.wikimedia.org/r/#/c/176000/ (merged)
https://gerrit.wikimedia.org/r/#/c/176285/ (merged)
https://gerrit.wikimedia.org/r/#/c/176286/ (merged)
https://gerrit.wikimedia.org/r/#/c/176946/ (merged)
https://gerrit.wikimedia.org/r/#/c/177222/ (merged)
https://gerrit.wikimedia.org/r/#/c/177223/ (merged)
https://gerrit.wikimedia.org/r/#/c/177551/ (merged)
https://gerrit.wikimedia.org/r/#/c/179923/ (merged)
https://gerrit.wikimedia.org/r/#/c/182824/ (merged)
https://gerrit.wikimedia.org/r/#/c/182825/ (merged)
https://gerrit.wikimedia.org/r/#/c/183040/ (merged)
https://gerrit.wikimedia.org/r/#/c/183267/ (merged)
https://gerrit.wikimedia.org/r/#/c/183268/ (merged)
https://gerrit.wikimedia.org/r/#/c/179924/
https://gerrit.wikimedia.org/r/#/c/183269/
https://gerrit.wikimedia.org/r/#/c/183313/
https://gerrit.wikimedia.org/r/#/c/183533/

Event Timeline

matthiasmullie claimed this task.
matthiasmullie raised the priority of this task from to Medium.
matthiasmullie updated the task description. (Show Details)
matthiasmullie changed Security from none to None.
matthiasmullie added a subscriber: matthiasmullie.
EBernhardson closed this task as Resolved.EditedApr 6 2015, 9:14 PM
EBernhardson added a subscriber: EBernhardson.

All linked CirrusSearch patches have been merged