Protected pages from creation don't show the "change protection" link and the current protection level
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Melos
	Dec 21 2014, 5:03 PM

Description

Protected pages from creation do not show the "change protection" link in the "more" tab
Ex.:
https://it.wikipedia.org/w/index.php?title=Utente:IndyJr/ProvaProtezione
https://it.wikipedia.org/w/index.php?title=Utente:IndyJr/ProvaProtezione1

Also current protection level is not shown, for ex. see
https://it.wikipedia.org/w/index.php?title=Utente:IndyJr/ProvaProtezione&action=unprotect
https://it.wikipedia.org/w/index.php?title=Utente:IndyJr/ProvaProtezione1&action=unprotect

Details

	Subject	Repo	Branch	Lines +/-
	Fix Title::loadRestrictions() for create-protected titles	mediawiki/core	master	+24 -7
	Improve/ sanitize protected_titles handling	mediawiki/core	master	+96 -38

Customize query in gerrit

Related Objects

Duplicates Merged Here: T109227: Content action link offers to "protect" a non-existent title that is already create protected

Event Timeline

Melos created this task.Dec 21 2014, 5:03 PM

Melos raised the priority of this task from to High.

Melos updated the task description. (Show Details)

Melos added a project: MediaWiki-Page-protection.

Melos changed Security from none to None.

Melos subscribed.

Melos added a subscriber: Legoktm.Dec 21 2014, 7:54 PM

Melos added a project: MediaWiki-Core-Team.Dec 22 2014, 4:46 PM

Did this work before? If yes, any idea when this broke?

@Melos: Why was "MediaWiki-CoreTeam" added here as a project?

Change 181423 had a related patch set uploaded (by Hoo man):
Improve/ sanitize protected_titles handling

https://gerrit.wikimedia.org/r/181423

Patch-For-Review

@hoo tracked this down to a regression in my MovePage patch.

The regression is due to moving the BC handling from callers of getTitleProtection() into getTitleProtection() itself. @hoo's patch tries to go a little further with that, but it doesn't go far enough and actually going far enough looks to me like it would turn out to be a lot of work.

We might be better served with the short-term solution of just reverting the part of the MovePage patch that moved the BC handling into getTitleProtection().

bd808 removed a project: MediaWiki-Core-Team.Apr 8 2015, 10:44 PM

Umherirrender merged a task: T109227: Content action link offers to "protect" a non-existent title that is already create protected.Aug 16 2015, 5:51 PM

Umherirrender added a subscriber: Chenzw.

Change 181423 abandoned by Hoo man:
Improve/ sanitize protected_titles handling

Reason:
I don't think I'll have time to work on this anytime soon.

https://gerrit.wikimedia.org/r/181423

hoo removed a project: Patch-For-Review.Mar 23 2016, 2:12 PM

Lahwaacz subscribed.Sep 20 2016, 10:12 PM

MGChecker subscribed.Nov 23 2016, 8:08 PM

Restricted Application added a subscriber: Luke081515. · View Herald TranscriptNov 23 2016, 8:08 PM

Change 335996 had a related patch set uploaded (by Anomie):
Fix Title::loadRestrictions() for create-protected titles

https://gerrit.wikimedia.org/r/335996

gerritbot added a project: Patch-For-Review.Feb 4 2017, 3:34 PM

Change 335996 merged by jenkins-bot:
[mediawiki/core] Fix Title::loadRestrictions() for create-protected titles

https://gerrit.wikimedia.org/r/335996

The fix should be deployed to WMF wikis with 1.29.0-wmf.15, see https://www.mediawiki.org/wiki/MediaWiki_1.29/Roadmap for the schedule.

ReleaseTaggerBot added projects: MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-03-07_(1.29.0-wmf.15)).Mar 6 2017, 9:00 PM

Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:41 PM

Protected pages from creation don't show the "change protection" link and the current protection levelClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Protected pages from creation don't show the "change protection" link and the current protection level
Closed, ResolvedPublic
Actions