Maniphest T85334

Migrate XML page generators to pagegenerators.py
Open, HighPublic
Actions

Description

Build tests for the current XML page generators in each of (four of six completed)

noreferences.py - 5a5f8ce4 - September 2007
redirect.py - 21ebff3a - July 2005
reflinks.py - 3a872a4d - May 2008
replace.py - 453ce536 - July 2005
template.py - 954233f - August 2005
weblinkchecker.py - 68bb3f70 - March 2014

And create a superclass in pagenerators.py to provide the common functionality with unit tests, so that each script only needs to either use filters or subclass the generic XML Page generator to perform the custom behaviour.

Details

	Subject	Repo	Branch	Lines +/-
	[IMPR] use pg.XMLDumpPageGenerator in replace.py	pywikibot/core	master	+22 -29
	replace.py: Migrate XML page generator to pagegenerators.py	pywikibot/core	master	+21 -87
	Migrate XmlDumpPageGenerator to pagegenerators	pywikibot/core	master	+126 -148
	Add reflinks xml tests	pywikibot/core	master	+629 -3
	Add tests for XML export v0.10	pywikibot/core	master	+172 -12

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T78452 Use pagegenerators consistently in scripts
		Open		None	T60942 Features to move from scripts to framework (tracking)
		Open		None	T85334 Migrate XML page generators to pagegenerators.py

Event Timeline

jayvdb created this task.Dec 26 2014, 6:54 AM

jayvdb claimed this task.

jayvdb raised the priority of this task from to High.

jayvdb updated the task description. (Show Details)

jayvdb added projects: Pywikibot-pagegenerators.py, Pywikibot-redirect.py, Pywikibot-weblinkchecker.py, Pywikibot-Scripts, Pywikibot-tests.

jayvdb added a subscriber: Unknown Object (MLST).

Change 181719 had a related patch set uploaded (by John Vandenberg):
Add reflinks xml tests

https://gerrit.wikimedia.org/r/181719

Patch-For-Review

Change 181713 had a related patch set uploaded (by John Vandenberg):
Add tests for XML export v0.10

https://gerrit.wikimedia.org/r/181713

Patch-For-Review

Change 181713 merged by jenkins-bot:
Add tests for XML export v0.10

https://gerrit.wikimedia.org/r/181713

Ricordisamoa subscribed.Dec 26 2014, 6:16 PM

Change 181719 merged by jenkins-bot:
Add reflinks xml tests

https://gerrit.wikimedia.org/r/181719

jayvdb mentioned this in rPWBCbb850121bd73: Add tests for XML export v0.10.Mar 4 2015, 8:46 AM

XZise mentioned this in rPWBC539cf6fc791d: Add reflinks xml tests.Mar 4 2015, 8:46 AM

jayvdb mentioned this in T100628: -start argument conflict.May 28 2015, 7:35 AM

jayvdb added a project: Pywikibot-replace.py.Jun 9 2015, 6:06 AM

jayvdb set Security to None.

jayvdb moved this task from Backlog to New tests needed on the Pywikibot-tests board.Jun 9 2015, 6:28 AM

jayvdb mentioned this in T57689: Implement -save option on replace.py core.Jun 25 2015, 10:28 PM

jayvdb updated the task description. (Show Details)Sep 20 2015, 8:55 AM

Change 239658 had a related patch set uploaded (by John Vandenberg):
Migrate XmlDumpPageGenerator to pagegenerators

https://gerrit.wikimedia.org/r/239658

Change 239658 merged by jenkins-bot:
Migrate XmlDumpPageGenerator to pagegenerators

https://gerrit.wikimedia.org/r/239658

jayvdb mentioned this in rPWBCa5ecb1299ae7: Migrate XmlDumpPageGenerator to pagegenerators.Sep 30 2015, 10:11 AM

jayvdb updated the task description. (Show Details)Jan 19 2016, 7:29 AM

jayvdb moved this task from Backlog to Compat only on the Pywikibot-weblinkchecker.py board.Jan 20 2016, 7:56 AM

Change 266018 had a related patch set uploaded (by Mpaa):
replace.py: Migrate XML page generator to pagegenerators.py

https://gerrit.wikimedia.org/r/266018

Change 266018 abandoned by Mpaa:
replace.py: Migrate XML page generator to pagegenerators.py

https://gerrit.wikimedia.org/r/266018

Dvorapa removed a project: Patch-For-Review.May 27 2018, 11:40 AM

• Phabricator_maintenance added a project: Pywikibot.Mar 23 2019, 10:16 PM

Aklapper removed a project: Pywikibot-Scripts.May 17 2019, 1:17 PM

Aklapper mentioned this in T224421: move_project script does not check if task is in both future parent and future subproject and does not remove future parent project.Aug 9 2019, 5:27 PM

Xqt removed jayvdb as the assignee of this task.Feb 19 2020, 6:55 AM

Change 769728 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] [IMPR] use pg.XMLDumpPageGenerator in replace.py

https://gerrit.wikimedia.org/r/769728

gerritbot added a project: Patch-For-Review.Mar 17 2022, 9:31 AM

Xqt moved this task from Compat only to Backlog on the Pywikibot-weblinkchecker.py board.Mar 18 2022, 1:22 AM

Xqt updated the task description. (Show Details)Mar 20 2022, 10:15 AM

Xqt updated the task description. (Show Details)

Change 769728 merged by Xqt:

[pywikibot/core@master] [IMPR] use pg.XMLDumpPageGenerator in replace.py

https://gerrit.wikimedia.org/r/769728

Xqt removed a project: Patch-For-Review.Mar 20 2022, 1:20 PM

Xqt updated the task description. (Show Details)Apr 15 2022, 6:36 AM

Xqt moved this task from Backlog to Extract generator from script on the Pywikibot-pagegenerators.py board.May 12 2022, 9:46 AM