Page MenuHomePhabricator
Create Task
Maniphest T85521

Do not include api action=flowthank when no Flow is installed
Closed, ResolvedPublic
Actions

Description

The extension Thanks is register the api module action=flowthank even when no Flow is installed on that wiki. This is useless and should be make conditionally.

Details

SubjectRepoBranchLines +/-
Make inclusion of API action=flowthank conditional on Flow being installedmediawiki/extensions/Thanksmaster+19 -9
Customize query in gerrit

Related Objects

Event Timeline

Umherirrender created this task.Dec 30 2014, 10:44 AM
Umherirrender raised the priority of this task from to Low.
Umherirrender updated the task description. (Show Details)
Umherirrender added projects: Thanks, StructuredDiscussions.
Umherirrender subscribed.
Legoktm added a project: good first task.Jun 16 2015, 6:53 PM
Legoktm subscribed.
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptJun 16 2015, 6:53 PM
• Mattflaschen-WMF assigned this task to happy5214.Jun 19 2015, 12:52 AM
• Mattflaschen-WMF subscribed.
jayvdb subscribed.Jun 19 2015, 12:55 AM
happy5214 mentioned this in T102164: Weekly reports for 'Implement Flow support in Pywikibot'.Jun 25 2015, 9:01 PM
gerritbot subscribed.Jun 25 2015, 9:29 PM

Change 220978 had a related patch set uploaded (by Happy5214):
Make inclusion of API action=flowthank conditional on Flow being installed

https://gerrit.wikimedia.org/r/220978

gerritbot added a project: Patch-For-Review.Jun 25 2015, 9:29 PM
gerritbot added a comment.Jun 25 2015, 10:34 PM

Change 220978 merged by jenkins-bot:
Make inclusion of API action=flowthank conditional on Flow being installed

https://gerrit.wikimedia.org/r/220978

happy5214 mentioned this in rMEXT3c880bf6249a: Updated mediawiki/extensions Project: mediawiki/extensions/Thanks….Jun 25 2015, 10:34 PM
happy5214 mentioned this in rETHAa6c8c093ab1a: Make inclusion of API action=flowthank conditional on Flow being installed.
Legoktm closed this task as Resolved.Jun 25 2015, 10:44 PM
• Forrestbot added a project: WMF-deploy-2015-06-30_(1.26wmf12).Jun 25 2015, 11:00 PM
• Forrestbot subscribed.
Legoktm removed a subscriber: • Forrestbot.Jun 29 2015, 5:50 PM
• DannyH moved this task from Untriaged to Resolved on the Collaboration-Team-Triage board.Jun 30 2015, 7:56 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits