Page MenuHomePhabricator

V+1 checks for non-whitelisted users are missing some linters included in V+2 voting checks
Closed, DeclinedPublic

Description

V+1 checks for non-whitelisted users are missing some linters included in V+2 voting checks.

In particular, the 'mediawiki-core-npm' job (part of V+2 checks) does JSCS checks, but the 'mediawiki-core-jslint' job (part of V+1 checks) doesn't. This discourages new developers. Example change where this was a problem: https://gerrit.wikimedia.org/r/#/c/182652/

Event Timeline

matmarex raised the priority of this task from to Needs Triage.
matmarex updated the task description. (Show Details)
matmarex added subscribers: matmarex, Krinkle.
Jdforrester-WMF set Security to None.

Patches welcome, but I don't expect this to be worked on before T47499: [EPIC] Run CI jobs in disposable VMs after which the 'check pipeline will no longer continue to exist.

hashar claimed this task.
hashar subscribed.

The changes should be Code-Reviewed +2 which would triggers the same set of job regardless of the original author trustiness.

It is surely annoying for non whitelisted persons but the inconsistency will be solved via T47499 which will let us run the same set of jobs regardless of user sending the patch.