Page MenuHomePhabricator

Selecting a target link and then selecting text inside the link creates a new link inside the existing target link.
Closed, ResolvedPublic

Description

If you click on a target link in the translation column and then highlight the text inside the link, a new target link will automatically be created inside the existing target link.

It should not be possible to add a link inside an existing link.
Selecting text inside a link should not automatically create a new link.

Event Timeline

Jsahleen raised the priority of this task from to Needs Triage.
Jsahleen updated the task description. (Show Details)
Jsahleen added subscribers: Aklapper, Jsahleen.
santhosh removed a project: Technical-Debt.
santhosh set Security to None.

Change 183812 had a related patch set uploaded (by Santhosh):
Do not create links for the selected text in a link

https://gerrit.wikimedia.org/r/183812

Patch-For-Review

Change 183812 merged by jenkins-bot:
Do not create links for the selected text in a link

https://gerrit.wikimedia.org/r/183812

The problem still persists.

clicking on the target link, displays the link card with the option to 'remove link'

Screen_Shot_2015-01-09_at_11.34.49_pm.png (558×1 px, 299 KB)

selecting the same text displays the 'add link' option

Screen_Shot_2015-01-09_at_11.35.14_pm.png (573×1 px, 299 KB)

If the 'add link' option is used, then link cards break for all other links:

Screen_Shot_2015-01-09_at_11.40.53_pm.png (585×1 px, 254 KB)

It is still possible to add a link inside another link. Selecting text inside a link does not automatically create a new link now, but if you select text inside a link you get the "Add link" card and clicking on "Add link" inserts a link inside the link.

The problem still persists.

clicking on the target link, displays the link card with the option to 'remove link'

Screen_Shot_2015-01-09_at_11.34.49_pm.png (558×1 px, 299 KB)

selecting the same text displays the 'add link' option

Screen_Shot_2015-01-09_at_11.35.14_pm.png (573×1 px, 299 KB)

If the 'add link' option is used, then link cards break for all other links:

Screen_Shot_2015-01-09_at_11.40.53_pm.png (585×1 px, 254 KB)

The problem mentioned in the earlier comment is a new bug and is reported in T86511. Closing the current task.