Page MenuHomePhabricator

[Regression wmf14] Cannot add any template, throws error TypeError: Cannot read property 'length' of null
Closed, ResolvedPublic1 Estimated Story Points

Description

Cannot add any template, throws error TypeError: Cannot read property 'length' of null

Event Timeline

Ryasmeen created this task.Jan 7 2015, 7:43 PM
Ryasmeen raised the priority of this task from to Unbreak Now!.
Ryasmeen updated the task description. (Show Details)
Ryasmeen added a project: VisualEditor.
Ryasmeen added a subscriber: Ryasmeen.

Screenshot attached

Change 183309 had a related patch set uploaded (by Catrope):
Work around $.parseHTML( '' ) returning null

https://gerrit.wikimedia.org/r/183309

Patch-For-Review

Krenair added a subscriber: Krenair.Jan 7 2015, 8:03 PM
Ryasmeen renamed this task from [Regression pre-wmf14]Cannot add any template, throws error TypeError: Cannot read property 'length' of null to [Regression wmf14]Cannot add any template, throws error TypeError: Cannot read property 'length' of null.Jan 7 2015, 8:06 PM
Ryasmeen set Security to None.

Change 183309 merged by jenkins-bot:
Work around $.parseHTML( '' ) returning null

https://gerrit.wikimedia.org/r/183309

Jdforrester-WMF renamed this task from [Regression wmf14]Cannot add any template, throws error TypeError: Cannot read property 'length' of null to [Regression wmf14] Cannot add any template, throws error TypeError: Cannot read property 'length' of null.Jan 7 2015, 9:11 PM

Change 183330 had a related patch set uploaded (by Jforrester):
Work around $.parseHTML( '' ) returning null

https://gerrit.wikimedia.org/r/183330

Patch-For-Review

I am not getting the error now after this fix, but still the template is appearing as an empty block.Separate issue?

I am not getting the error now after this fix, but still the template is appearing as an empty block.Separate issue?

Yes, that's T86046: [Regression wmf14] Response from parseFragment is blank content, meaning newly-inserted or -modified content is blank until saving.

Change 183330 merged by jenkins-bot:
Work around $.parseHTML( '' ) returning null

https://gerrit.wikimedia.org/r/183330

Change 183511 had a related patch set uploaded (by Jforrester):
Bump VisualEditor to include I659cc1f and If133a9d

https://gerrit.wikimedia.org/r/183511

Patch-For-Review

Change 183511 merged by jenkins-bot:
Bump VisualEditor to include I659cc1f and If133a9d

https://gerrit.wikimedia.org/r/183511

Verified the fix in test2

Verified in en.wiki