Page MenuHomePhabricator
Create Task
Maniphest T86056

[Regression wmf14] Cannot add any template, throws error TypeError: Cannot read property 'length' of null
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To
Catrope
Authored By
Ryasmeen
Jan 7 2015, 7:43 PM
Tags
Referenced Files
F26901: Screen_Shot_2015-01-07_at_1.16.41_PM_1.png
Jan 7 2015, 9:17 PM
F26889: Screen_Shot_2015-01-07_at_11.43.54_AM.png
Jan 7 2015, 7:44 PM
Subscribers
Aklapper
Catrope
Jdforrester-WMF
Krenair
Ryasmeen
Tokens
"Haypence" token, awarded by RandomDSdevel.

Description

Cannot add any template, throws error TypeError: Cannot read property 'length' of null

Details

SubjectRepoBranchLines +/-
Bump VisualEditor to include I659cc1f and If133a9dmediawiki/corewmf/1.25wmf14+1 -1
Work around $.parseHTML( '' ) returning nullmediawiki/extensions/VisualEditorwmf/1.25wmf14+2 -1
Work around $.parseHTML( '' ) returning nullmediawiki/extensions/VisualEditormaster+2 -1
Customize query in gerrit

Related Objects

Event Timeline

Ryasmeen created this task.Jan 7 2015, 7:43 PM
Ryasmeen raised the priority of this task from to Unbreak Now!.
Ryasmeen updated the task description. (Show Details)
Ryasmeen added a project: VisualEditor.
Ryasmeen subscribed.

Screenshot attached

Screen_Shot_2015-01-07_at_11.43.54_AM.png (700×1 px, 146 KB)

Ryasmeen moved this task from To Triage to External and Administrivia on the VisualEditor board.Jan 7 2015, 7:56 PM
gerritbot added a project: Patch-For-Review.Jan 7 2015, 8:02 PM

Change 183309 had a related patch set uploaded (by Catrope):
Work around $.parseHTML( '' ) returning null

https://gerrit.wikimedia.org/r/183309

Patch-For-Review

Krenair subscribed.Jan 7 2015, 8:03 PM
Ryasmeen renamed this task from [Regression pre-wmf14]Cannot add any template, throws error TypeError: Cannot read property 'length' of null to [Regression wmf14]Cannot add any template, throws error TypeError: Cannot read property 'length' of null.Jan 7 2015, 8:06 PM
Ryasmeen set Security to None.
gerritbot added a comment.Jan 7 2015, 8:06 PM

Change 183309 merged by jenkins-bot:
Work around $.parseHTML( '' ) returning null

https://gerrit.wikimedia.org/r/183309

Catrope mentioned this in rEVEDf71054d67d1c: Work around $.parseHTML( '' ) returning null.Jan 7 2015, 8:06 PM
Jdforrester-WMF renamed this task from [Regression wmf14]Cannot add any template, throws error TypeError: Cannot read property 'length' of null to [Regression wmf14] Cannot add any template, throws error TypeError: Cannot read property 'length' of null.Jan 7 2015, 9:11 PM
Jdforrester-WMF added a project: VisualEditor-MediaWiki-Templates.
gerritbot added a comment.Jan 7 2015, 9:16 PM

Change 183330 had a related patch set uploaded (by Jforrester):
Work around $.parseHTML( '' ) returning null

https://gerrit.wikimedia.org/r/183330

Patch-For-Review

Jdforrester-WMF closed this task as Resolved.Jan 7 2015, 9:16 PM
Jdforrester-WMF assigned this task to Catrope.
Jdforrester-WMF edited projects, added WMF-deploy-2015-01-07_(1.25wmf14), WMF-deploy-2015-01-14_(1.25wmf15); removed Patch-For-Review.
Jdforrester-WMF moved this task from External and Administrivia to FY 18-19 Q3/Q4 on the VisualEditor board.
Ryasmeen added a comment.Jan 7 2015, 9:17 PM

I am not getting the error now after this fix, but still the template is appearing as an empty block.Separate issue?

Screen_Shot_2015-01-07_at_1.16.41_PM_1.png (436×1 px, 124 KB)

Jdforrester-WMF subscribed.Jan 7 2015, 11:56 PM
In T86056#960843, @Ryasmeen wrote:

I am not getting the error now after this fix, but still the template is appearing as an empty block.Separate issue?

Screen_Shot_2015-01-07_at_1.16.41_PM_1.png (436×1 px, 124 KB)

Yes, that's T86046: [Regression wmf14] Response from parseFragment is blank content, meaning newly-inserted or -modified content is blank until saving.

gerritbot added a comment.Jan 8 2015, 3:28 PM

Change 183330 merged by jenkins-bot:
Work around $.parseHTML( '' ) returning null

https://gerrit.wikimedia.org/r/183330

Jdforrester-WMF mentioned this in rEVED1ba54837c271: Work around $.parseHTML( '' ) returning null.Jan 8 2015, 3:30 PM
gerritbot added a project: Patch-For-Review.Jan 8 2015, 3:37 PM

Change 183511 had a related patch set uploaded (by Jforrester):
Bump VisualEditor to include I659cc1f and If133a9d

https://gerrit.wikimedia.org/r/183511

Patch-For-Review

gerritbot added a comment.Jan 8 2015, 4:12 PM

Change 183511 merged by jenkins-bot:
Bump VisualEditor to include I659cc1f and If133a9d

https://gerrit.wikimedia.org/r/183511

Jdforrester-WMF mentioned this in rMW4bc979e7ddcf: Bump VisualEditor to include I659cc1f and If133a9d.Jan 8 2015, 4:12 PM
Ryasmeen added a comment.Jan 8 2015, 8:23 PM

Verified the fix in test2

Ryasmeen added a project: Verified-in-Phase0.Jan 8 2015, 8:24 PM
Ryasmeen added a comment.Jan 15 2015, 10:49 PM

Verified in en.wiki

Ryasmeen added a project: Verified-in-Phase2.Jan 15 2015, 10:49 PM
Jdforrester-WMF added a project: VisualEditor 2014/15 Q3 blockers.Jan 23 2015, 11:32 PM
Jdforrester-WMF edited a custom field.Jan 23 2015, 11:55 PM
Jdforrester-WMF moved this task from Nominated to Done on the VisualEditor 2014/15 Q3 blockers board.Feb 3 2015, 5:02 PM
Jdforrester-WMF removed a project: Patch-For-Review.Feb 19 2015, 9:36 PM
RandomDSdevel awarded a token.Mar 5 2015, 7:19 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL