Page MenuHomePhabricator
Create Task
Maniphest T86249

Move validation out of the form classes
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Validation should be handled by the adapter model or a helper class, not the UI layer.

Details

SubjectRepoBranchLines +/-
Move more validation out of GatewayPage and into the adapter.mediawiki/extensions/DonationInterfacemaster+100 -132
Customize query in gerrit

Related Objects
Search...

Event Timeline

awight created this task.Jan 8 2015, 10:18 PM
awight renamed this task from Move validation and any other adapter-appropriate stuff out of the form classes to Move validation out of the form classes.
awight raised the priority of this task from to Needs Triage.
awight updated the task description. (Show Details)
awight added a project: Fundraising-Backlog-Old.
awight moved this task to DI Refactor on the Fundraising-Backlog-Old board.
awight updated the task description. (Show Details)
awight set Security to None.
awight subscribed.
gerritbot added a project: Patch-For-Review.Jan 8 2015, 11:01 PM

Change 63823 had a related patch set uploaded (by Awight):
Move more validation out of GatewayPage and into the adapter.

https://gerrit.wikimedia.org/r/63823

Patch-For-Review

gerritbot added a comment.Jan 14 2015, 9:44 AM

Change 184010 had a related patch set uploaded (by Awight):
DataValidator uses GatewayAdapter object

https://gerrit.wikimedia.org/r/184010

Patch-For-Review

awight added a project: § Fundraising Sprint Abba.Jan 14 2015, 11:10 PM
awight moved this task from In Analysis to In Development on the § Fundraising Sprint Abba board.
awight triaged this task as Medium priority.Jan 14 2015, 11:24 PM
awight edited a custom field.Jan 14 2015, 11:38 PM
• atgo assigned this task to awight.Jan 14 2015, 11:39 PM
• atgo edited a custom field.
awight added a comment.Jan 14 2015, 11:40 PM

Note to self: make a second card for other validation cleanup.

• atgo added a project: § Fundraising Sprint Beastie Boys.Jan 15 2015, 12:14 AM
• atgo moved this task from In Analysis to In Development on the § Fundraising Sprint Beastie Boys board.
awight removed a subtask: T86945: Clean up DonationInterface validation.Jan 16 2015, 6:20 PM
awight moved this task from In Development to Pending Code Review on the § Fundraising Sprint Beastie Boys board.
awight added a parent task: T86251: Move any remaining controller logic out of the form classes.Jan 16 2015, 7:08 PM
• atgo added a project: § Fundraising Sprint the Cure.Jan 28 2015, 11:40 PM
• atgo moved this task from In Analysis to Pending Code Review on the § Fundraising Sprint the Cure board.
gerritbot subscribed.Jan 30 2015, 2:32 AM

Change 63823 merged by jenkins-bot:
Move more validation out of GatewayPage and into the adapter.

https://gerrit.wikimedia.org/r/63823

awight mentioned this in rEDOIb9f7d7848a1e: Move more validation out of GatewayPage and into the adapter..Jan 30 2015, 2:32 AM
awight moved this task from DI Refactor to AWight brooding on on the Fundraising-Backlog-Old board.Feb 5 2015, 6:56 AM
awight moved this task from Pending Code Review to Done on the § Fundraising Sprint the Cure board.Feb 5 2015, 7:06 AM

(Strange, gerritbot did not record that 184010 was merged.)

awight removed a project: Patch-For-Review.Feb 5 2015, 7:08 AM
• atgo closed this task as Resolved.Feb 7 2015, 12:47 AM
• atgo subscribed.
Diffusion mentioned this in rMEXTe0e7af428b1e: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface….Mar 11 2015, 6:25 AM
awight moved this task from AWight brooding on to Backlog on the Fundraising-Backlog-Old board.Apr 1 2015, 9:38 PM
• atgo added a project: Fundraising-Backlog.Jun 30 2015, 10:16 PM
• atgo moved this task from Triage to Closed Sprint Work Q3 1415 on the Fundraising-Backlog board.Jun 30 2015, 10:18 PM
• mmodell removed a subscriber: awight.Jun 22 2017, 9:52 PM
• DStrine edited projects, added Fr-tech-archived-from-FY-2014/15; removed Fundraising-Backlog.Jan 11 2018, 9:29 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL