Page MenuHomePhabricator

Clean up PaymentMethod so it becomes useful
Open, NormalPublic0 Story Points

Description

Refactor out the static data. Payment methods are described by and implemented by adapters, so couple to that class.

Even better, rewrite PaymentMethod so it can represent incomplete method specifications, like a payment method preference == "cc" or "paypal". Then we can use that object during GatewayFormChoosing.

Event Timeline

awight created this task.Jan 8 2015, 10:29 PM
awight raised the priority of this task from to Needs Triage.
awight updated the task description. (Show Details)
awight moved this task to DI Refactor on the Fundraising-Backlog-Old board.
awight added a subscriber: awight.

Change 183630 had a related patch set uploaded (by Awight):
make paymentmethod non-static

https://gerrit.wikimedia.org/r/183630

Patch-For-Review

Change 183752 had a related patch set uploaded (by Awight):
Move function into the base class

https://gerrit.wikimedia.org/r/183752

Patch-For-Review

Change 183752 merged by jenkins-bot:
Move function into the base class

https://gerrit.wikimedia.org/r/183752

atgo triaged this task as Normal priority.Jan 15 2015, 12:15 AM
atgo added a subscriber: atgo.

@awight estimate this please

atgo edited a custom field.Jan 16 2015, 7:56 PM
atgo assigned this task to awight.Jan 29 2015, 12:47 AM
awight added a comment.Feb 5 2015, 7:33 AM

(Not carrying into sprint Devo)

Change 183630 merged by jenkins-bot:
Make paymentmethod non-static

https://gerrit.wikimedia.org/r/183630

awight removed awight as the assignee of this task.Feb 7 2016, 1:25 AM
mmodell removed a subscriber: awight.Jun 22 2017, 9:39 PM