Page MenuHomePhabricator
Create Task
Maniphest T86270

Add support in JsonContent for non-object structures (e.g. array)
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

The News/Journal/Book/Website options under Cite menu is missing now.

IMG_0068.jpg (768×1 px, 37 KB)

Details

SubjectRepoBranchLines +/-
JsonContent: Support non-object values as root structuremediawiki/corewmf/1.25wmf14+85 -33
JsonContent: Support non-object values as root structuremediawiki/corewmf/1.25wmf15+85 -33
JsonContent: Support non-object values as root structuremediawiki/coremaster+85 -33
Customize query in gerrit

Related Objects

Event Timeline

Ryasmeen created this task.Jan 9 2015, 12:06 AM
Ryasmeen raised the priority of this task from to Needs Triage.
Ryasmeen updated the task description. (Show Details)
Ryasmeen added projects: VisualEditor, VisualEditor-MediaWiki-Mobile.
Ryasmeen subscribed.
Krenair subscribed.Jan 9 2015, 12:10 AM

cannot reproduce

Krenair added a comment.Jan 9 2015, 2:03 AM

Still couldn't reproduce it, but I notice https://test2.wikipedia.org/wiki/MediaWiki:Visualeditor-cite-tool-definition.json is not showing anything - I wonder if that could be related.

@Ryasmeen, if you still get this issue, can you paste the output of mw.msg( 'visualeditor-cite-tool-definition.json' ) while VE is open here?

Ryasmeen added a comment.Jan 9 2015, 8:03 PM

No, I am not getting it anymore in test2

Ryasmeen closed this task as Resolved.Jan 9 2015, 8:18 PM
Ryasmeen set Security to None.
Krenair added a comment.Jan 9 2015, 8:22 PM

There's definitely something wrong there though - we noticed that trying to change the page I linked to returns "Invalid content data".

Krenair added subscribers: ori, Krinkle.EditedJan 9 2015, 9:03 PM

Looks like this would be caused by https://gerrit.wikimedia.org/r/#/c/177171/ - CCing Timo and Ori.

Krenair reopened this task as Open.Jan 9 2015, 9:13 PM
Krenair edited projects, added VisualEditor-MediaWiki, MediaWiki-ContentHandler; removed VisualEditor-MediaWiki-Mobile.
Ryasmeen triaged this task as High priority.Jan 9 2015, 11:05 PM
Ryasmeen lowered the priority of this task from High to Medium.
Ryasmeen moved this task from To Triage to Freezer on the VisualEditor board.
Jdforrester-WMF renamed this task from Citation options are now missing in test2.m.wikipedia.org to [Regression 1.25wmf14] JSON content blocks that aren't objects (arrays, literals, …) don't display and can't be saved.Jan 15 2015, 4:28 PM
Jdforrester-WMF raised the priority of this task from Medium to High.
Jdforrester-WMF added a project: Regression.
Jdforrester-WMF mentioned this in T86748: [Regression 1.25wmf14] HTML of JSON blocks (e.g. Schema pages) appears garbled.
Krinkle added a comment.EditedJan 16 2015, 1:48 AM

MediaWiki core's JsonContent handler only supports values of which the root structure is an object. This is why message [visualeditor-specialcharinspector-characterlist-insert](https://test2.wikipedia.org/w/index.php?title=MediaWiki:Visualeditor-specialcharinspector-characterlist-insert) works fine, but message visualeditor-cite-tool-definition.json (which is an array) is broken.

While the validation for it having to be an object is new in, it never supported non-objects. This is why these MediaWiki pages didn't get the green/grey/white boxes rendering like Meta-Wiki Schema pages do. The fact that it allowed saving was a bug, and it rendering the page as wikitext instead of JSON visualisation was an undocumented fallback.

The VisualEditor MediaWiki extension is setting the content model for these two messages to JSON in [VisualEditorHooks::onContentHandlerDefaultModelFor](https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/1a4c821da/VisualEditor.hooks.php#L47-L59). Until MediaWiki core supports arrays, VE should remove the content model from those pages.

Krinkle renamed this task from [Regression 1.25wmf14] JSON content blocks that aren't objects (arrays, literals, …) don't display and can't be saved to Add support in JsonContent for non-object structures (e.g. array).Jan 16 2015, 1:50 AM
Krinkle lowered the priority of this task from High to Lowest.
Krinkle updated the task description. (Show Details)
Krinkle removed a project: Regression.
Krinkle removed a subscriber: Ryasmeen.
Krinkle claimed this task.Jan 16 2015, 2:01 AM
Krinkle raised the priority of this task from Lowest to Medium.
gerritbot added a project: Patch-For-Review.Jan 16 2015, 3:25 AM
gerritbot subscribed.

Change 185385 had a related patch set uploaded (by Krinkle):
JsonContent: Support non-object values as root structure

https://gerrit.wikimedia.org/r/185385

Patch-For-Review

Jdforrester-WMF subscribed.Jan 16 2015, 5:22 PM
gerritbot added a comment.Jan 16 2015, 9:03 PM

Change 185385 merged by jenkins-bot:
JsonContent: Support non-object values as root structure

https://gerrit.wikimedia.org/r/185385

Jdforrester-WMF added a project: WMF-deploy-2015-02-04_(1.25wmf16).Jan 16 2015, 9:37 PM
Ryasmeen merged a task: T87054: Cite options are missing in test2 for VE now.Jan 16 2015, 10:04 PM
Ryasmeen subscribed.
ori mentioned this in rMW7c340aed294a: JsonContent: Support non-object values as root structure.Jan 17 2015, 12:04 AM
Jdforrester-WMF closed this task as Resolved.Jan 17 2015, 12:21 AM
gerritbot added a comment.Jan 17 2015, 1:00 AM

Change 185584 had a related patch set uploaded (by Krinkle):
JsonContent: Support non-object values as root structure

https://gerrit.wikimedia.org/r/185584

Patch-For-Review

gerritbot added a comment.Jan 17 2015, 1:01 AM

Change 185585 had a related patch set uploaded (by Krinkle):
JsonContent: Support non-object values as root structure

https://gerrit.wikimedia.org/r/185585

Patch-For-Review

Krinkle updated the task description. (Show Details)Jan 17 2015, 1:21 AM
gerritbot added a comment.Jan 17 2015, 1:46 AM

Change 185584 merged by jenkins-bot:
JsonContent: Support non-object values as root structure

https://gerrit.wikimedia.org/r/185584

gerritbot added a comment.Jan 17 2015, 1:46 AM

Change 185585 merged by jenkins-bot:
JsonContent: Support non-object values as root structure

https://gerrit.wikimedia.org/r/185585

Krinkle mentioned this in rMW3ccf2b06c37a: JsonContent: Support non-object values as root structure.Jan 17 2015, 1:47 AM
Krinkle mentioned this in rMW4df4e89b2010: JsonContent: Support non-object values as root structure.
Ryasmeen added a comment.Jan 17 2015, 2:35 AM

The citation options are now appearing in test2.

Ryasmeen added a project: Verified-in-Phase0.Jan 17 2015, 2:35 AM
Jdforrester-WMF removed a project: Patch-For-Review.Jan 30 2015, 6:22 PM
RandomDSdevel awarded a token.Mar 5 2015, 8:43 PM
Jdforrester-WMF added a project: VisualEditor 2014/15 Q3 blockers.Mar 29 2015, 11:27 PM
Jdforrester-WMF edited a custom field.Mar 29 2015, 11:32 PM
Jdforrester-WMF moved this task from Nominated to Done on the VisualEditor 2014/15 Q3 blockers board.Mar 29 2015, 11:49 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits