Page MenuHomePhabricator
Create Task
Maniphest T86281

Broken unicode character in mobile footer (ZERO WIDTH NON-JOINER)
Closed, ResolvedPublic
Actions

Description

Screen_Shot_2015-01-09_at_01.26.38.png (384×988 px, 38 KB)

escape('Mobile‌Desktop')
"Mobile%u200CDesktop"
encodeURIComponent('Mobile‌Desktop')
"Mobile%E2%80%8CDesktop"

Details

SubjectRepoBranchLines +/-
Replace zwnj in the footer with a nicer CSS solutionmediawiki/extensions/MobileFrontendmaster+8 -2
Customize query in gerrit

Related Objects

Event Timeline

Krinkle created this task.Jan 9 2015, 1:28 AM
Krinkle raised the priority of this task from to Needs Triage.
Krinkle updated the task description. (Show Details)
Krinkle added projects: Mobile, Web-Team-Backlog, Regression.
Krinkle subscribed.
• KLans_WMF moved this task from Incoming to 2015-16 Q4 on the Web-Team-Backlog board.Jan 9 2015, 6:14 PM
• bmansurov subscribed.Jan 13 2015, 1:00 AM

@Krinkle, I cannot reproduce this. Can you please share a URL where this happens? Thanks.

Krinkle added a comment.Jan 13 2015, 8:44 PM

Nearly every page of every mobile page is affected in Chrome 42.

Location: https://en.m.wiktionary.org/wiki/Wiktionary:Main_Page
Browser: Google Chrome Canary 42 for Mac.

Screen_Shot_2015-01-13_at_12.42.40.png (306×1 px, 37 KB)

And while it should be reported upstream that this character renders as tufu in Chrome 42 and above, the character shouldn't be there in the output stream. It being visible or not is just an escalation of that issue, not the issue itself. The character is there in all browsers.

kaldari subscribed.Jan 15 2015, 6:23 PM

The zwnj was added to address an issue in Arabic (https://phabricator.wikimedia.org/T62916). zwnj is supposed to be a non-printing character, so it makes no sense that Chrome would render it as tofu. I guess we'll have to figure out a work-around in the meantime :(

kaldari added a comment.Jan 15 2015, 6:34 PM

Reported upstream: https://code.google.com/p/chromium/issues/detail?id=449209&thanks=449209&ts=1421346838

kaldari added a comment.Jan 15 2015, 7:17 PM

Confirmed that the Firefox bug the zwnj fixes is still an active bug :(

kaldari added a comment.Jan 15 2015, 7:22 PM

Actually, it looks like there is disagreement about whether or not it is actually a bug, so it's unlikely to be changed any time soon. (See thread at http://lists.w3.org/Archives/Public/www-international/2014JanMar/0212.html)

kaldari added a comment.Jan 15 2015, 7:35 PM

There are two courses of action we could take:

  1. Wait and see if the tofu bug in Chrome Canary makes it to the official Chrome release.
  2. Remove the zwnj from the footer and let the Arabic wikis add it locally.

Any opinions on which we should choose?

kaldari set Security to None.Jan 15 2015, 7:35 PM
kaldari added a subscriber: Amire80.
gerritbot added a project: Patch-For-Review.Jan 18 2015, 1:17 AM
gerritbot subscribed.

Change 185659 had a related patch set uploaded (by Amire80):
Replace zwnj in the footer with a nicer CSS solution

https://gerrit.wikimedia.org/r/185659

Patch-For-Review

Amire80 added a comment.Jan 18 2015, 1:19 AM

See the patch. It kills the zwnj and replaces it with a CSS trick. It's still a hack, but less ugly than zwnj. It would make more sense to simply apply something like unicode-bidi: embed to the <li>, but apparently Firefox doesn't render it correctly either :(

Amire80 claimed this task.Jan 18 2015, 12:10 PM
Amire80 added a project: I18n.
Amire80 added a comment.Jan 18 2015, 12:17 PM

BTW, it also fixes another issue that is not easily visible on a vanilla local testing instance: the "Terms of use" and "Privacy policy" links in the bottom of mobile Wikipedia pages also have this incorrect disconnection, so they need either this patch or an additional ZWNJ, which would add to the ugliness. (I only have the "Privacy policy" link on my instance.)

Amire80 mentioned this in rEMFR2455df0ee317: Replace zwnj in the footer with a nicer CSS solution.Jan 19 2015, 6:13 PM
Jdlrobson closed this task as Resolved.Jan 20 2015, 9:46 PM
Jdlrobson subscribed.

Patch was merged

aude subscribed.Apr 9 2015, 10:58 AM

we also have this issue in wikidata

http://snag.gy/7R1aQ.jpg

not sure we can / want to work around it here with css, since it is a translation.

anyway, added comment int he chromium bug ticket.

aude added a comment.Apr 9 2015, 10:58 AM

on https://www.wikidata.org/wiki/Q76?uselang=fa

pasted_file (279×523 px, 34 KB)

• Phabricator_maintenance moved this task from 2015-16 Q4 to 2014-15 Q3 on the Web-Team-Backlog board.Mar 7 2018, 4:20 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL