Page MenuHomePhabricator
Create Task
Maniphest T86334

Add tests for ResourceLoaderImageModule and ResourceLoaderImage
Closed, ResolvedPublic
Actions

Description

https://gerrit.wikimedia.org/r/#/c/165922/ adds new classes without use in core, which needs tests to ensure it works and allow testing without extensions

Details

SubjectRepoBranchLines +/-
ResourceLoaderImage: Add basic testsmediawiki/coremaster+245 -94
ResourceLoaderImageModule: Add basic testsmediawiki/coremaster+160 -0
Customize query in gerrit

Related Objects

Event Timeline

Umherirrender created this task.Jan 9 2015, 7:07 PM
Umherirrender raised the priority of this task from to Needs Triage.
Umherirrender updated the task description. (Show Details)
Umherirrender added projects: MediaWiki-ResourceLoader, MediaWiki-Core-Tests.
Umherirrender added subscribers: Umherirrender, • TrevorParscal, matmarex.
Aklapper triaged this task as Low priority.Jan 10 2015, 4:27 PM
gerritbot subscribed.Mar 23 2015, 9:36 PM

Change 199128 had a related patch set uploaded (by Bartosz Dziewoński):
ResourceLoaderImageModule: Add basic tests

https://gerrit.wikimedia.org/r/199128

gerritbot added a project: Patch-For-Review.Mar 23 2015, 9:36 PM
Jdforrester-WMF closed this task as Resolved.Mar 29 2015, 4:06 PM
Jdforrester-WMF assigned this task to matmarex.
Jdforrester-WMF edited projects, added WMF-deploy-2015-04-01_(1.25wmf24); removed Patch-For-Review.
Jdforrester-WMF set Security to None.
matmarex reopened this task as Open.Mar 29 2015, 4:07 PM

ResourceLoaderImage still has nothing. I'm actually writing some test for it right now.

gerritbot added a comment.Mar 29 2015, 5:39 PM

Change 200482 had a related patch set uploaded (by Bartosz Dziewoński):
ResourceLoaderImageModule: Add tests for ResourceLoaderImage

https://gerrit.wikimedia.org/r/200482

gerritbot added a project: Patch-For-Review.Mar 29 2015, 5:39 PM
gerritbot added a comment.Mar 29 2015, 7:03 PM

Change 199128 merged by jenkins-bot:
ResourceLoaderImageModule: Add basic tests

https://gerrit.wikimedia.org/r/199128

matmarex mentioned this in rMW5ed35b04c99a: ResourceLoaderImageModule: Add basic tests.Mar 29 2015, 7:03 PM
gerritbot added a comment.Mar 30 2015, 6:10 PM

Change 200482 merged by jenkins-bot:
ResourceLoaderImage: Add basic tests

https://gerrit.wikimedia.org/r/200482

matmarex mentioned this in rMWd469b379554f: ResourceLoaderImage: Add basic tests.Mar 30 2015, 6:10 PM
matmarex closed this task as Resolved.Mar 31 2015, 11:52 AM
matmarex removed a project: Patch-For-Review.
matmarex removed a subscriber: gerritbot.
hashar awarded a token.Mar 31 2015, 12:53 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits