Page MenuHomePhabricator

Cannot add url values as an anonymous or unconfirmed user
Closed, ResolvedPublic

Description

I am unable to save url values (for url data type) when I am logged out or am a new (unconfirmed user) on Wikidata. (also happens on master or beta.wikidata)

http://snag.gy/3R0pG.jpg

This appears to be caused by changes in the ConfirmEdit extension.

https://gerrit.wikimedia.org/r/#/c/177746/

Event Timeline

aude raised the priority of this task from to Needs Triage.
aude updated the task description. (Show Details)
aude subscribed.
aude set Security to None.

I still can't save urls after reverting https://gerrit.wikimedia.org/r/#/c/136323/. When reverting to before https://gerrit.wikimedia.org/r/#/c/177746/ ("Use the shared parse on API edit"), then saving urls works again.

Lydia_Pintscher moved this task from incoming to ready to go on the Wikidata board.
Lydia_Pintscher added a subscriber: tstarling.

the issue seems to be the change to use EditFilterMergedContent hook, which Wikibase also runs in addition to core. There obviously is some compatibility issue.

Since we have no obvious / easy way to display captchas now in Wikibase, the easy short-term solution might be just not to enable captchas for entity namespaces.

I would prefer that ConfirmEdit and Wikibase work more gracefully together, though, when enabled for entity namespaces, and also look into why there is no error text displayed in the popup when a user tries to enter a url value.

The missing error message should be solved with this change, which adds an error message to the status object returned by ConfirmEdit:
https://gerrit.wikimedia.org/r/#/c/184381

I don't know, what the best way would be for ConfirmEdit to handle Wikibase. No CAPTCHA? Wikibase should be able to request the CAPTCHA image from the api result to display it and build a new api request to save the edit and pass the captchaid and the result of the user.

I hope we can resolve this asap :)

gerritbot subscribed.

Change 186828 had a related patch set uploaded (by Hoo man):
Exempt Item and Property namespaces from ConfirmEdit

https://gerrit.wikimedia.org/r/186828

Patch-For-Review

Change 186828 merged by Hoo man:
Exempt Item and Property namespaces from ConfirmEdit

https://gerrit.wikimedia.org/r/186828

Change deployed.