Maniphest T86751

[Task] Refactor onFormat autocomment handling code and add tests
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	aude
	Jan 14 2015, 10:41 AM

Tags

Referenced Files

None

Subscribers

Lydia_Pintscher

Description

the code that parses and handles autocomments in wikibase is in the Wikibase hooks class, as static method.

it duplicates quite a bit of code from the Linker class and has no tests.

Details

	Subject	Repo	Branch	Lines +/-
	Factor AutoCommentFormatter out of hook handler	mediawiki/extensions/Wikibase	master	+227 -44

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T90435 [Epic] Wikidata watchlist improvements (client)
		Open		None	T108688 [Story] meaningful edit summaries on the client
		Resolved		Addshore	T86751 [Task] Refactor onFormat autocomment handling code and add tests

Event Timeline

aude created this task.Jan 14 2015, 10:41 AM

aude raised the priority of this task from to Needs Triage.

aude updated the task description. (Show Details)

aude added projects: Wikidata, MediaWiki-extensions-WikibaseRepository.

aude subscribed.

Lydia_Pintscher triaged this task as High priority.Jan 14 2015, 11:52 AM

Lydia_Pintscher set Security to None.

Lydia_Pintscher moved this task from incoming to needs discussion or investigation on the Wikidata board.

this code needs to be in it's own class(es) and refactored so that it is usable for summaries in the client *and* repo

Lydia_Pintscher added a project: Wikidata-Sprint-2015-08-18.Aug 18 2015, 1:30 PM

Lydia_Pintscher subscribed.

Lydia_Pintscher moved this task from needs discussion or investigation to in progress on the Wikidata board.Aug 20 2015, 9:09 AM

daniel updated the task description. (Show Details)Aug 21 2015, 12:39 PM

• Jonas assigned this task to Addshore.Aug 24 2015, 8:47 AM

• Jonas moved this task from Backlog to Doing on the Wikidata-Sprint-2015-08-18 board.

• Jonas updated the task description. (Show Details)Aug 24 2015, 8:50 AM

Patch at https://gerrit.wikimedia.org/r/#/c/221582/

daniel updated the task description. (Show Details)Aug 31 2015, 11:34 AM

Change 221582 merged by jenkins-bot:
Factor AutoCommentFormatter out of hook handler

https://gerrit.wikimedia.org/r/221582

Diffusion mentioned this in rMEXTc44bd29d70f3: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Aug 31 2015, 5:25 PM

aude mentioned this in rEWBAf56149d236c6: Factor AutoCommentFormatter out of hook handler.Aug 31 2015, 5:25 PM

Merged: https://gerrit.wikimedia.org/r/#/c/234979/

JanZerebecki moved this task from Doing to Done on the Wikidata-Sprint-2015-08-18 board.Aug 31 2015, 6:49 PM

Lydia_Pintscher closed this task as Resolved.Sep 2 2015, 8:37 AM