Code cleanup
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Physikerwelt
	Jan 18 2015, 3:20 PM

Description

I did some code cleanup using static code analysis with phpStorm.
Some parts are already reviewd but 3 Changes are still missing.
https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/Math+branch:master+topic:staticCodeAnalysis,n,z

Subject	Repo	Branch	Lines +/-
Avoid call to method that could be undefined	mediawiki/extensions/Math	master	+1 -1
Add type hinting for newFromMd5 constructor	mediawiki/extensions/Math	master	+1 -0
Remove unused XML namespace	mediawiki/extensions/Math	master	+1 -1

Mentioned In: rMEXT6777e3d92cb2: Updated mediawiki/extensions Project: mediawiki/extensions/Math…
rMEXT87d63d59a337: Updated mediawiki/extensions Project: mediawiki/extensions/Math…
rEMATdc12796ced76: Merge changes from master to debug
rEMAT4d7f6f8b77a0: Add type hinting for newFromMd5 constructor
rEMAT37e61853b5d8: Remove unused XML namespace

Physikerwelt raised the priority of this task from to Needs Triage.

Physikerwelt updated the task description. (Show Details)

Physikerwelt added a project: Math.

Change 178506 had a related patch set uploaded (by Physikerwelt):
Remove unused XML namespace

Change 178507 had a related patch set uploaded (by Physikerwelt):
Avoid call to method that could be undefined

Change 178508 had a related patch set uploaded (by Physikerwelt):
Add type hinting for newFromMd5 constructor

Change 178506 merged by jenkins-bot:
Remove unused XML namespace

Change 178508 merged by jenkins-bot:
Add type hinting for newFromMd5 constructor

Change 178507 abandoned by Krinkle:
Avoid call to method that could be undefined

Done.