Page MenuHomePhabricator

Run phpunit tests for EventLogging before merging
Closed, ResolvedPublic

Description

https://gerrit.wikimedia.org/r/#/c/185223/ was merged without test failures, but it broke merging in other components which run mediawiki-extensions-zend. This should not happen.

Event Timeline

Nikerabbit raised the priority of this task from to Needs Triage.
Nikerabbit updated the task description. (Show Details)
Nikerabbit subscribed.
Nikerabbit triaged this task as Unbreak Now! priority.Jan 19 2015, 9:25 AM

Simple revert of the linked patch did not help. I'm reusing this bug for solving the failure as well and marking tentatively with highest priority as it blocks other work in many places.

hashar claimed this task.
hashar subscribed.

The build logs are gone so I am not sure what happened :-/ Maybe it was caused by another change? Feel free to reopen if something similar occurs again.

And I forgot: on +2 we run mediawiki-extensions-hhvm and mediawiki-extensions-zend which clone EventLogging and run tests registered by the UnitTestList hook.