There shouldn't be any patches that have been applied and unmerged on deployment-prep for more than a day.
Description
Description
Details
Details
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T53494 Use Beta cluster as a true canary for code deployments (epic) | |||
| Open | None | T87220 Minimize infrastructure differences between Beta Cluster and production | |||
| Resolved | yuvipanda | T87616 Set up an alert for unmerged changes in deployment-prep | |||
| Declined | yuvipanda | T88238 Convert git-sync-upstream script from bash to python |
Event Timeline
Comment Actions
production has a check for this, should be among this:
modules/monitoring/manifests/icinga/git_merge.pp: description => "Unmerged changes on repository ${title}",
modules/puppetmaster/manifests/monitoring.pp: # Check for unmerged changes that have been sitting for more than one minute.
let's reuse the same thing here?
Comment Actions
@Dzahn: We can't, since beta's puppetmaster automatically rebases on production and so we'll need to alert on conflicts as well. Plus that is run on prod as an active check, which we can't do on labs.
Comment Actions
Change 188017 had a related patch set uploaded (by Yuvipanda):
puppetmaster: Send cherry-picked commit count stats to statsd
Comment Actions
Change 188017 merged by Yuvipanda:
puppetmaster: Send cherry-picked commit count stats to statsd
Comment Actions
Change 188037 had a related patch set uploaded (by Yuvipanda):
beta: Add check for cherry-picked commits
Comment Actions
YESSSS http://shinken.wmflabs.org/service/deployment-salt/Long%20lived%20cherry-picks%20on%20puppetmaster
alerts if there has been more than 1 cherry-pick in the last 6 hours. Will be moved to 0 once T76392 is fixed