Page MenuHomePhabricator

Set up an alert for unmerged changes in deployment-prep
Closed, ResolvedPublic

Description

There shouldn't be any patches that have been applied and unmerged on deployment-prep for more than a day.

Details

Related Gerrit Patches:

Event Timeline

yuvipanda claimed this task.
yuvipanda raised the priority of this task from to Needs Triage.
yuvipanda updated the task description. (Show Details)
Dzahn added a subscriber: Dzahn.Jan 28 2015, 6:12 PM

production has a check for this, should be among this:

modules/monitoring/manifests/icinga/git_merge.pp: description => "Unmerged changes on repository ${title}",
modules/puppetmaster/manifests/monitoring.pp: # Check for unmerged changes that have been sitting for more than one minute.

let's reuse the same thing here?

greg triaged this task as Normal priority.Jan 28 2015, 11:40 PM
greg moved this task from To Triage to In-progress on the Beta-Cluster-Infrastructure board.

@Dzahn: We can't, since beta's puppetmaster automatically rebases on production and so we'll need to alert on conflicts as well. Plus that is run on prod as an active check, which we can't do on labs.

gerritbot added a subscriber: gerritbot.

Change 188017 had a related patch set uploaded (by Yuvipanda):
puppetmaster: Send cherry-picked commit count stats to statsd

https://gerrit.wikimedia.org/r/188017

Patch-For-Review

Change 188017 merged by Yuvipanda:
puppetmaster: Send cherry-picked commit count stats to statsd

https://gerrit.wikimedia.org/r/188017

Change 188037 had a related patch set uploaded (by Yuvipanda):
beta: Add check for cherry-picked commits

https://gerrit.wikimedia.org/r/188037

Patch-For-Review

Change 188037 merged by Yuvipanda:
beta: Add check for cherry-picked commits

https://gerrit.wikimedia.org/r/188037

yuvipanda closed this task as Resolved.Feb 2 2015, 12:24 PM

YESSSS http://shinken.wmflabs.org/service/deployment-salt/Long%20lived%20cherry-picks%20on%20puppetmaster

alerts if there has been more than 1 cherry-pick in the last 6 hours. Will be moved to 0 once T76392 is fixed