Is currently somewhat complicated, so that would simplify things. Also would help send stats to stads easily.
Description
Description
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T53494 Use Beta cluster as a true canary for code deployments (epic) | |||
| Open | None | T87220 Minimize infrastructure differences between Beta Cluster and production | |||
| Resolved | yuvipanda | T87616 Set up an alert for unmerged changes in deployment-prep | |||
| Declined | yuvipanda | T88238 Convert git-sync-upstream script from bash to python |
Event Timeline
Comment Actions
@hashar it's in operations/puppet: modules/puppetmaster/templates/git-sync-upstream.erb
Comment Actions
I don't agree at all. The script is extremely simple and is just doing some very simple operations with git. I don't see why rewriting this in python would give us any advantage.
Comment Actions
@greg it's a bc bug because of the task it blocks - I want to move it to python so we can send stats to graphite about how many cherry-picked commits are there, and have it alert on that :)
Comment Actions
@Joe I think bash is a terrible language when you aren't just executing a sequence of commands (with or without piping). My personal guideline is to rewrite to python whenever there's more than one control structure in the script and / or when I am going to add a new feature to it, which are both true here.
Comment Actions
On second thoughts, a lot of the complexity in that bash script can go away, so I'm just going to do that instead.
Still think complicated bash scripts should be moved to python, though :)
Comment Actions
(simplification done in https://gerrit.wikimedia.org/r/188019) and https://gerrit.wikimedia.org/r/#/c/188018/