Page MenuHomePhabricator
Create Task
Maniphest T88204

deployment-mx should not send out emails with $domain part set as wikimedia.org
Closed, ResolvedPublic
Actions

Description

The new deployment-mx routes emails from the beta-cluster - and still have the $domain part of Return-Path header set to 'wikimedia.org'. This will cause for bounces to come back all the way till polonium - which is not the intended path. Probably, beta should have something like wmflabs.org set as the $domain part so that bounce emails will come back to deployment-mx.
The current return path for an email sent from http://deployment.wikimedia.beta.wmflabs.org/ is :

Return-Path: <wiki-deploymentwiki-pg-niuja1-g/Qo8rG/uI9DaDAg@wikimedia.org>

After adding DNS records for deployment-mx. This should become something like :

Return-Path: <wiki-deploymentwiki-pg-niuja1-g/Qo8rG/uI9DaDAg@wmflabs.org

Details

SubjectRepoBranchLines +/-
Set $domain part override for emails from betaoperations/mediawiki-configmaster+1 -0
Customize query in gerrit

Related Objects

Event Timeline

01tonythomas created this task.Jan 31 2015, 9:28 AM
01tonythomas raised the priority of this task from to Needs Triage.
01tonythomas updated the task description. (Show Details)
01tonythomas added a project: Beta-Cluster-Infrastructure.
01tonythomas added subscribers: 01tonythomas, Jgreen, Legoktm and 2 others.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 31 2015, 9:28 AM
01tonythomas set Security to None.Jan 31 2015, 9:28 AM
01tonythomas added subscribers: faidon, hoo.
01tonythomas added a subscriber: yuvipanda.
01tonythomas updated the task description. (Show Details)Jan 31 2015, 9:30 AM
01tonythomas added a comment.Jan 31 2015, 9:59 AM

Looks like the rewrite happens from the deployment wiki level - consider this header from the Deployment wiki email

Received: from apache by deployment-mediawiki01.eqiad.wmflabs with local (Exim 4.82)
	(envelope-from <wiki-deploymentwiki-pg-nitobf-UEI5RedsqbyokF35@wikimedia.org>)
	id 1YFzWZ-0002Ji-0N
	for 01tonythomas@gmail.com; Tue, 27 Jan 2015 06:21:19 +0000

The envolope-from already have the $domain part set as wikimedia.org right after the wiki send the email out.

scfc subscribed.Jan 31 2015, 10:08 AM

That should probably be beta.wmflabs.org or something similar to avoid confusion with other Labs projects.

gerritbot added a project: Patch-For-Review.Jan 31 2015, 2:07 PM
gerritbot subscribed.

Change 187905 had a related patch set uploaded (by 01tonythomas):
Set $domain part override for emails from beta

https://gerrit.wikimedia.org/r/187905

Patch-For-Review

gerritbot added a comment.Jan 31 2015, 2:19 PM

Change 187905 merged by jenkins-bot:
Set $domain part override for emails from beta

https://gerrit.wikimedia.org/r/187905

01tonythomas closed this task as Resolved.Jan 31 2015, 2:22 PM
01tonythomas claimed this task.

Thanks @hoo for the weekend +2 :)

greg moved this task from To Triage to Done on the Beta-Cluster-Infrastructure board.Feb 1 2015, 7:50 PM
01tonythomas mentioned this in rOMWC79ba9de42d96: Set $domain part override for emails from beta.Mar 3 2015, 9:01 PM
• Phabricator_maintenance removed a subscriber: yuvipanda.Jun 7 2017, 6:55 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits