Clear search button is missing on mobile search once you swith to full-text Search
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Etonkovidova
	Feb 5 2015, 12:26 AM

Description

Go to https://en.m.wikipedia.org/w/index.php?search
Enter some search criteria, star trek - and switch to the 'Search within pages'
The search criteria will still be displayed in the Search field - click somewhere in the field.

the sandwich icon(title="Open main menu" href="/wiki/Special:MobileMenu" class="icon icon-mainmenu" id="mw-mf-main-menu-button") will change to Close button(button class="icon icon-cancel cancel") - click on it - the search criteria won't be cleared.

The behavior is inconsistent with normal(not full-text) search.

Details

	Subject	Repo	Branch	Lines +/-
	Don't hide the clear button when the search input is not empty	mediawiki/extensions/MobileFrontend	master	+5 -1

Customize query in gerrit

Related Objects

Mentioned In: rMEXT77cb3492f5ba: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend…
rEMFRfb76c6d8549a: Don't hide the clear button when the search input is not empty
Mentioned Here: T73203: Editor overlay should have close icon on first screen

Event Timeline

Etonkovidova created this task.Feb 5 2015, 12:26 AM

Etonkovidova raised the priority of this task from to Needs Triage.

Etonkovidova updated the task description. (Show Details)

Etonkovidova added a project: Mobile.

Etonkovidova subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 5 2015, 12:26 AM

Etonkovidova updated the task description. (Show Details)Feb 5 2015, 12:28 AM

Etonkovidova added a project: Web-Team-Backlog.

Etonkovidova set Security to None.

mobile_web_clearing_search.mov5 MBDownload

Related: T73203

I think it should be a "back" button (arrow), this X isn't intended to clear the search string :) What says Design ?

• KLans_WMF renamed this task from 'Close' button does clear search criteria on the full-text Search Result page to 'Close' button does not clear search criteria on the full-text Search Result page.Feb 6 2015, 6:12 PM

• KLans_WMF moved this task from Incoming to 2015-16 Q4 on the Web-Team-Backlog board.

I think all that's needed for this is for the same clear button that we use for normal search to be added to search-within-pages search.

seems like a basic bug, the icon is missing, no design changes need.

• KLans_WMF triaged this task as Medium priority.Mar 13 2015, 8:24 PM

• KLans_WMF added a project: good first task.

• bmansurov claimed this task.Mar 19 2015, 11:27 PM

Change 198143 had a related patch set uploaded (by Bmansurov):
Don't hide the clear button when the search input is not empty

https://gerrit.wikimedia.org/r/198143

gerritbot added a project: Patch-For-Review.Mar 19 2015, 11:29 PM

• bmansurov moved this task from 2015-16 Q4 to Needs Prioritization on the Web-Team-Backlog board.Mar 19 2015, 11:29 PM

phuedx removed a project: Patch-For-Review.Mar 20 2015, 3:38 PM

Change 198143 merged by jenkins-bot:
Don't hide the clear button when the search input is not empty

https://gerrit.wikimedia.org/r/198143

phuedx closed this task as Resolved.Mar 20 2015, 3:43 PM

phuedx subscribed.

• bmansurov mentioned this in rEMFRfb76c6d8549a: Don't hide the clear button when the search input is not empty.Mar 23 2015, 3:53 PM

Diffusion mentioned this in rMEXT77cb3492f5ba: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Mar 23 2015, 3:56 PM

• Phabricator_maintenance moved this task from Needs Prioritization to 2014-15 Q3 on the Web-Team-Backlog board.Mar 7 2018, 4:23 AM

Clear search button is missing on mobile search once you swith to full-text SearchClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Clear search button is missing on mobile search once you swith to full-text Search
Closed, ResolvedPublic
Actions