Page MenuHomePhabricator

Clear search button is missing on mobile search once you swith to full-text Search
Closed, ResolvedPublic

Description

  1. Go to https://en.m.wikipedia.org/w/index.php?search
  2. Enter some search criteria, star trek - and switch to the 'Search within pages'
  3. The search criteria will still be displayed in the Search field - click somewhere in the field.

the sandwich icon(title="Open main menu" href="/wiki/Special:MobileMenu" class="icon icon-mainmenu" id="mw-mf-main-menu-button") will change to Close button(button class="icon icon-cancel cancel") - click on it - the search criteria won't be cleared.

The behavior is inconsistent with normal(not full-text) search.

Event Timeline

Etonkovidova raised the priority of this task from to Needs Triage.
Etonkovidova updated the task description. (Show Details)
Etonkovidova added a project: Mobile.
Etonkovidova added a subscriber: Etonkovidova.
Florian added a subscriber: Florian.

Related: T73203

I think it should be a "back" button (arrow), this X isn't intended to clear the search string :) What says Design ?

KLans_WMF renamed this task from 'Close' button does clear search criteria on the full-text Search Result page to 'Close' button does not clear search criteria on the full-text Search Result page.Feb 6 2015, 6:12 PM
KLans_WMF moved this task from Incoming to 2015-16 Q4 on the Readers-Web-Backlog board.

I think all that's needed for this is for the same clear button that we use for normal search to be added to search-within-pages search.

Jaredzimmerman-WMF renamed this task from 'Close' button does not clear search criteria on the full-text Search Result page to Clear search button is missing on mobile search once you swith to full-text Search.Mar 12 2015, 3:23 AM
Jaredzimmerman-WMF removed a project: Design.

seems like a basic bug, the icon is missing, no design changes need.

KLans_WMF triaged this task as Medium priority.Mar 13 2015, 8:24 PM
KLans_WMF added a project: good first task.

Change 198143 had a related patch set uploaded (by Bmansurov):
Don't hide the clear button when the search input is not empty

https://gerrit.wikimedia.org/r/198143

Change 198143 merged by jenkins-bot:
Don't hide the clear button when the search input is not empty

https://gerrit.wikimedia.org/r/198143

phuedx added a subscriber: phuedx.